GNOME Bugzilla – Bug 116224
gnome-theme-manager infinite loop selecting ./themes and segmentation fault
Last modified: 2004-12-22 21:47:04 UTC
Overview Description: when i try to add a new theme from .theme/, its keeps fetching files there like forever, also if i cancel it a segmentation ocurrs. Steps to reproduce the problem: 1. click on desktop-preferences - themes - install theme 2. select .themes/ 3. wait transfer forever..., or press cancel button. Actual Results: if you wait the transfer it seems to transfer files forever, if you press cancel button this message appears: gnome-theme-manager process 687 has crashed due to a fatal error. (segmentation fault). Expected Results: select the theme and install it in the current environment, or if the theme isnt ok it have the proper error response. how often happend? always i trie. Additional Information: Debugging Information: Backtrace was generated from '/usr/bin/gnome-theme-manager' (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)...[New Thread 16384 (LWP 610)] [New Thread 32769 (LWP 612)] [New Thread 16386 (LWP 613)] (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... (no debugging symbols found)...(no debugging symbols found)...(no debugging symbols found)... 0x40b9ef29 in wait4 () from /lib/libc.so.6
+ Trace 38256
Thread 3 (Thread 16386 (LWP 613))
The issue was, when the /root/.themes/ folder is selected, it tries to copy the ".themes" of the source file name from /root location to the folder /root/.themes/.themes. This created an infinite loop. So i solved the loop. I am attaching a patch too. But I am not sure, do i have to pop out a error message. I havent done it. Please tell me do i have to do it. In other places of the code also, they have just returned, ignoring the error that occurs, like null filename. I have been consistent with it.
Created attachment 21372 [details] [review] Removes the infinite loop
Jody, do you mind taking a look at this when you have a chance?
A good start but failing silently is not really an option. Please add a message dialog to explain why nothing happens. Thanks
Created attachment 21610 [details] [review] Added a error dialog with a message in the patch.
Please the patch with the message dialog to HEAD, and the patch without it to gnome-2-4