GNOME Bugzilla – Bug 115637
Gstreamer Properties needs HIGification
Last modified: 2003-07-15 07:25:30 UTC
Incoming! :) regs, Chris
Created attachment 17668 [details] [review] Proposed patch against HEAD - Plus marks "Custom" menu items for translation
Created attachment 17669 [details] Screenshot illustrating my changes.
Patch => Priority High, added some keywords. I assume Iain is responsible for this bug as he's the lead developer/maintainer and according to AUTHORS nobody is responsible for gstreamer-properties. regs, Chris
Really set priority to high. regs, Chris
I was noticing that alot of the changes to the glade file are dealing with the size of boarders. I'm not aware of anything in the HIG which sepecifies those, are they just for aesthedic appeal? Note: This patch adds translation for the custom title, it also cleans up and names most of the stuff in the glade file, and it adjusts many of the boards and spacing in the dialog.
Adjusting borders, spacings etc. is an important part of the HIG. See http://developer.gnome.org/projects/gup/hig/1.0/layout.html#window-layout-spacing . As you're not familiar with this, it's probably a better idea to let this review sb. with HIG + usability experience. regs, Chris
Wow, I can't believe that I missed that in look through the HIG. Sorry. Anyway, these changes look good to me. I think that since these are HIG bugfixes they need to go in. I've checked them into HEAD. Thanks.