After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 115637 - Gstreamer Properties needs HIGification
Gstreamer Properties needs HIGification
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: general
2.3.x
Other All
: High minor
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 116366
 
 
Reported: 2003-06-20 22:04 UTC by Christian Neumair
Modified: 2003-07-15 07:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch against HEAD - Plus marks "Custom" menu items for translation (52.38 KB, patch)
2003-06-20 22:07 UTC, Christian Neumair
none Details | Review
Screenshot illustrating my changes. (19.23 KB, image/png)
2003-06-20 22:09 UTC, Christian Neumair
  Details

Description Christian Neumair 2003-06-20 22:04:52 UTC
Incoming! :)

regs,
 Chris
Comment 1 Christian Neumair 2003-06-20 22:07:56 UTC
Created attachment 17668 [details] [review]
Proposed patch against HEAD - Plus marks "Custom" menu items for translation
Comment 2 Christian Neumair 2003-06-20 22:09:18 UTC
Created attachment 17669 [details]
Screenshot illustrating my changes.
Comment 3 Christian Neumair 2003-06-20 22:40:46 UTC
Patch => Priority High, added some keywords.
I assume Iain is responsible for this bug as he's the lead
developer/maintainer and according to AUTHORS nobody is responsible
for gstreamer-properties.

regs,
 Chris
Comment 4 Christian Neumair 2003-06-20 22:41:29 UTC
Really set priority to high.

regs,
 Chris
Comment 5 Ted Gould 2003-07-08 05:36:27 UTC
I was noticing that alot of the changes to the glade file are dealing
with the size of boarders.  I'm not aware of anything in the HIG which
sepecifies those, are they just for aesthedic appeal?

Note: This patch adds translation for the custom title, it also cleans
up and names most of the stuff in the glade file, and it adjusts many
of the boards and spacing in the dialog.
Comment 6 Christian Neumair 2003-07-09 09:28:08 UTC
Adjusting borders, spacings etc. is an important part of the HIG.
See
http://developer.gnome.org/projects/gup/hig/1.0/layout.html#window-layout-spacing
.
As you're not familiar with this, it's probably a better idea to let
this review sb. with HIG + usability experience.

regs,
 Chris
Comment 7 Ted Gould 2003-07-15 07:25:30 UTC
Wow, I can't believe that I missed that in look through the HIG.  Sorry.

Anyway, these changes look good to me.  I think that since these are
HIG bugfixes they need to go in.  I've checked them into HEAD.

Thanks.