GNOME Bugzilla – Bug 114823
[patch] videocrop interface proposal
Last modified: 2004-12-22 21:47:04 UTC
Instead of what i was expecting, crop_top -- how many pixels to crop from the top crop_bottom -- etc .. crop_left crop_right videocrop requires the new x,y,width,height of the image which means that my app needs to query or know the original width & height. Can we support both styles of crop specification? If i submit a patch, will it get applied?
Created attachment 17430 [details] [review] add relative crop properties
Adding PATCH keyword and setting priority to high because of the patch.
There is some use in doing it this way, yes... However, don't forget that in the end, if you're making a userfriendly app with graphical userinterface and cropping tool (like the GIMP) which implements this plugin, you'll still need to know the height/width. :). Anyway, I think we can actually just go over to *only* this new interface, I like it more, to be honest. What do others think?
The new interface is much easier for command-line usage. However, i think we should maintain backward compatibility, at least for one major release. We can add a warning for the deprecated properties (or something).
We have previously had no plans for keeping compatibility between stable releases. Attempting to do so would make 0.8 very heavy with backward compatibility code.
If someone actually takes the leap and commits my patch then i'll be motivated to remove or deprecate the old API.
Created attachment 17921 [details] [review] this?
I fixed some typos and stylish'ities. Does the above work? If so, I'll apply that.
I've got this patch locally, I'll apply it with my caps remake. *** This bug has been marked as a duplicate of 116387 ***