After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 114597 - [PATCH] URL regexp shouldn't match newline
[PATCH] URL regexp shouldn't match newline
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: Havoc Pennington
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-06 20:37 UTC by Olav Vitters
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not match \t\r\n (836 bytes, patch)
2003-06-06 20:39 UTC, Olav Vitters
none Details | Review

Description Olav Vitters 2003-06-06 20:37:51 UTC
In Bugzilla mail the URL for 'Created an attachment' are within '(' and
')', with no text after the ')', example:
  --> (http://bugzilla.mozilla.org/attachment.cgi?id=123&action=view)

When viewing such a mail in Mutt (CLI mailer), gnome-terminal thinks the
')' is part of the URL. This is because the regexp matches a newline.

To reproduce (using only a shell):
1. Open a new gnome-terminal window
2. Type in: echo '(http:///a.b.c/defghi) foobar'
3. Press Enter
4. Mouse the mouse over 'defghi'
-- http://a.b.c/defghi is underscored
5. Type in: echo '(http:///a.b.c/jklmno)'
6. Press Enter
7. Mouse the mouse over 'jklmno'

Expected result:
http:///a.b.c/jklmno is underscored

Actual result:
http:///a.b.c/jklmno) is underscored
Note the ')'

I will attach a patch which adds \t, \r and \n to the characters that can't
be matched.
Comment 1 Olav Vitters 2003-06-06 20:39:48 UTC
Created attachment 17254 [details] [review]
Do not match \t\r\n
Comment 2 Havoc Pennington 2003-06-06 21:06:58 UTC
Patch looks good to me.
Comment 3 Mariano Suárez-Alvarez 2003-06-29 04:31:53 UTC
Commited