After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 114190 - Non-ASCII message in gnome-applets gives xgettext warning and msgmerge error
Non-ASCII message in gnome-applets gives xgettext warning and msgmerge error
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: keyboard-accessibility (accessx-status)
git master
Other All
: High major
: ---
Assigned To: bill.haneman
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-06-01 10:25 UTC by Christian Rose
Modified: 2005-08-15 01:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Escape ae character properly, mark it for translation again, add neccessary stuff to POTFILES.in. (1.21 KB, patch)
2003-09-21 06:59 UTC, Christian Neumair
needs-work Details | Review

Description Christian Rose 2003-06-01 10:25:30 UTC
From accessx-status/applet.c:843:

		glyph_pixbuf = accessx_status_applet_get_glyph_pixbuf (sapplet, 
								       widget,
								       pixbuf, 
								       fg, 
								       bg,
								       N_("æ"));


This gives the following xgettext warning:

xgettext: warning: The following msgid contains non-ASCII characters.
                   This will cause problems to translators who use a
character encoding
                   different from yours. Consider using a pure ASCII msgid
instead.
                   æ
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence
xgettext: invalid multibyte sequence


Using non-ASCII characters in messages marked for translation is not
allowed by gettext. Please see
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#use-ascii.
Comment 1 Kevin Vandersloot 2003-06-01 13:56:12 UTC
Bill: we now have a bugzilla catagory for the accessx applet. We
should probably put you as the default owner of this catagory.
Comment 2 Christian Rose 2003-06-02 23:38:01 UTC
Failed to mention that msgmerge also ends with an error after the
xgettext warnings.
Comment 3 bill.haneman 2003-06-03 08:59:53 UTC
Sorry to leave this one hanging, (quick) fix in CVS (removed l10n
macro from non-ASCII string).
Will fix "properly" with en_ locale soon... thanks.
Comment 4 Christian Neumair 2003-09-21 06:59:41 UTC
Created attachment 20151 [details] [review]
Escape ae character properly, mark it for translation again, add neccessary stuff to POTFILES.in.
Comment 5 bill.haneman 2003-09-22 10:40:01 UTC
Christian N: I didn't know gettext strings could contain non-ASCII
characters...  if your fix is acceptable to the rest of the i18n and
l10n teams, then I prefer it, but it's not obvious that everyone will
agree that it's right.

Menthos? what do you think?
Comment 6 Christian Rose 2003-09-22 11:25:12 UTC
The use of UTF-8 in gettext messages requires both a very recent
intltool (intltool >= 0.27) and a recent GNU gettext version (GNU
gettext >= 0.12). See bug 99005 for some discussion. Other intltool
versions and gettext implementations are AFAIK not supporting UTF-8
inside msgids, and will give warnings and errors when compiling the po
catalogs.

Hence, if the above requirements aren't acceptable, I still think we
should very much avoid using UTF-8 inside gettext messages.
Comment 7 bill.haneman 2003-12-11 23:53:29 UTC
I think we should apply cneumair's patch now.  Jody, is that OK with you?
Comment 8 alexander.winston 2004-01-31 05:03:58 UTC
I would really like to see this go in soon, being a Unicode geek and
all. :)
Comment 9 Dennis Smit 2004-02-04 23:26:36 UTC
Is the patch working[tm] ?, Kevin can i commit ?
Comment 10 Kevin Vandersloot 2004-02-05 14:06:36 UTC
We would need to do a configure check for gettext. I don't even have
gettext >= .12. 
Christian: Is gettext >= .12 required by any other gnome modules? What
do you suggest?
Comment 11 Christian Rose 2004-02-05 20:59:50 UTC
> Is gettext >= .12 required by any other gnome modules?

Not that I know of. Gnumeric HEAD depends on it, but then it isn't
part of the GNOME desktop release either.


> What do you suggest?

Difficult to know, as I don't even know what this character is used
for (the presence of a translator comment would surely help).
Comment 12 bill.haneman 2004-02-06 17:24:46 UTC
translator comment should be 

/* a representative single character resulting when 'AltGr' is
pressed; this character is used to indicate that AltGr (also known as
ISO_Level_Shift) is active. */

Permission to apply patch which adds this comment requested.
Comment 13 bill.haneman 2004-02-16 13:06:10 UTC
pinging maintainer again... permission to apply comment patch above
requested.
Comment 14 Kevin Vandersloot 2004-02-16 22:51:51 UTC
Uhh, Bill, _you_ are the maintainer ;) Why do you need permission? For
which patch?
Comment 15 bill.haneman 2004-02-17 00:26:39 UTC
Hi Kevin:

OK, I didn't know I had maintainer rights in perpetuity to this applet
just 'cause I wrote it.  Sounds good - I'll make the change.  I will
however post patches before doing anything significant to the applet
in future.
Comment 16 Christian Rose 2004-02-17 00:59:35 UTC
Please also note that we're in string freeze... changing now needs
approval.
Comment 17 bill.haneman 2004-02-17 13:19:38 UTC
Christian: the patch applies a comment, it does not change a string. 
I do not see why this requires permission.
Comment 18 Christian Rose 2004-02-19 06:28:24 UTC
The only patch I can see in this report (patch 20151) adds a new message.
Comment 19 bill.haneman 2004-02-24 19:37:19 UTC
See my comment above: I wrote "permission to apply patch which adds
this comment", meaning _a_ patch which applied the comment, not
permission to add the previous patch.  The patch was so trivial I put
it inline in my comment.

The translator comment has now been added.  However the string has
_not_ been marked for translation.  I think that should wait until
2.8, when lots of build tools will be upgraded, IIRC.  It doesn't look
like there's agreement about requiring gettext 0.12 in 2.6.
Comment 20 Eunice Chang 2004-04-29 16:26:25 UTC
Comment on attachment 20151 [details] [review]
Escape ae character properly, mark it for translation again, add neccessary stuff to POTFILES.in.

This patch is being marked as 'committed'; however, there appears to be some
confusion about 'comment' and 'string'. Anyone want to clarify this?
Comment 21 bill.haneman 2004-04-29 17:16:21 UTC
patch was _not_ committed.  Possibly can commit something like it to HEAD (not
2.6), with the appropriate configure.in changes to require gettext 0.12.
Comment 22 Dennis Smit 2004-06-17 21:38:30 UTC
When escaping the string do we also need gettext 0.12 ?
Comment 23 Christian Rose 2004-06-19 19:46:47 UTC
Yes. Gettext understands C-style escaped characters, and gettext < 0.12 will
still bork if it finds one which indicate a character outside the 7-bit ASCII
range. So escaping makes no difference.
Comment 24 Danielle Madeley 2004-10-30 09:35:28 UTC
What is the status of this bug? Surely this is resolved through the
gettext/intltool requirements of GNOME2.8/2.10?
Comment 25 Danielle Madeley 2005-01-03 18:06:02 UTC
Ping!
Comment 26 Christian Rose 2005-01-03 23:44:12 UTC
I think this can be closed. I cannot reproduce the original problem with current
tools.