After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113649 - themable colors for hyperlinks
themable colors for hyperlinks
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal enhancement
: Medium API
Assigned To: gtk-bugs
gtk-bugs
AP3
: 125288 (view as bug list)
Depends on: 114355
Blocks:
 
 
Reported: 2003-05-24 19:57 UTC by Dave Bordoley [Not Reading Bug Mail]
Modified: 2006-01-24 00:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch which fixes the bug (1.85 KB, patch)
2004-04-09 05:02 UTC, Leena Gunda
needs-work Details | Review
patch with suggested changes (1.88 KB, patch)
2004-04-12 11:42 UTC, Leena Gunda
none Details | Review

Description Dave Bordoley [Not Reading Bug Mail] 2003-05-24 19:57:42 UTC
Hyperlinks are becoming pretty common in desktops. It would probably be
good to provide gtk rc file theming for unvisited and visited link colors.
I imagine this will be needed in GtkAbout if it supports hyperlinking.
Currently most apps just hardcode the colors to blue and red which is
probably bad for a11y, though i'm not sure.
Comment 1 Dave Bordoley [Not Reading Bug Mail] 2003-11-20 07:39:53 UTC
*** Bug 125288 has been marked as a duplicate of this bug. ***
Comment 2 bill.haneman 2003-11-20 14:21:22 UTC
yes, it's an accessibility problem all right.  For some users this
will make links nearly invisible (depending on contrast and their
color vision, etc.).
Comment 3 Leena Gunda 2004-04-09 05:01:03 UTC
Attaching a patch where I am installing gtkwidget class style properties for
visited and unvisited link colors.
Comment 4 Leena Gunda 2004-04-09 05:02:21 UTC
Created attachment 26496 [details] [review]
patch which fixes the bug
Comment 5 Owen Taylor 2004-04-09 13:55:54 UTC
Comment on attachment 26496 [details] [review]
patch which fixes the bug

Compare handling of cursor-color in gtkwidget.c for correct property type.
Comment 6 Leena Gunda 2004-04-12 11:42:31 UTC
Created attachment 26577 [details] [review]
patch with suggested changes
Comment 7 Christian Persch 2004-08-19 11:05:53 UTC
Comment on attachment 26577 [details] [review]
patch with suggested changes

Is this ready to be committed?
Comment 8 Misu Moldovan 2004-09-10 12:19:07 UTC
This is more than an accessibility issue for people with color vision problems.
This bug affects all the existing dark GTK themes and some are pretty popular
(you get dark blue links on dark backgrounds and other stuff like that). 

Apps like Evolution, Mozilla Mail, Thunderbird and pretty much any GTK+
application that uses links in gtk widgets is affected. Others (like Balsa) have
custom preferences for link colors, Gaim is also pretty cool with GtkIMHtml. But
the solution is the hands of the GTK+ developers. Please solve this once and for
all...
Comment 9 Calum Benson 2004-10-21 16:46:58 UTC
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs.
 Filter on "SUN A11Y SPAM" to ignore.
Comment 10 Christian Persch 2005-10-03 11:32:05 UTC
The gtkaboutdialog installs a 'link-color' style property, so when this is
checked in it should be chanaged to use it. Also bug 314808 can use this.
Comment 11 Matthias Clasen 2006-01-24 00:22:09 UTC
2006-01-23  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkwidget.c: Add link-color and visited-link-color style
	properties.  (#113649, Leena Gunda)

	* gtk/gtkaboutdialog.c: Use the new style properties here instead
	of the about dialogs own link-color property.