After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113615 - Van Gogh plug-in ignores selection [perf]
Van Gogh plug-in ignores selection [perf]
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other Linux
: Normal enhancement
: Future
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks: 141797
 
 
Reported: 2003-05-23 21:29 UTC by Maurits Rijk
Modified: 2006-03-17 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gimp plugin jpeg2000 0.1.1 (126.17 KB, application/octet-stream)
2004-08-10 05:57 UTC, Florian TRAVERSE
  Details
Compute only on the selection (2.23 KB, patch)
2006-03-17 15:39 UTC, Karine Delvare
committed Details | Review

Description Maurits Rijk 2003-05-23 21:29:17 UTC
The Van Gogh plug-in always operates on the complete image, ignoring the
current selection.
Comment 1 Sven Neumann 2003-05-25 14:28:58 UTC
The plug-in does respect the selection unless you ask it to create a
new image.
Comment 2 Maurits Rijk 2003-05-25 17:31:07 UTC
I doubt it (after quick scan of code), since the results of
gimp_drawable_mask_bounds are never used.
Comment 3 Sven Neumann 2003-05-25 17:52:00 UTC
The plug-in may work on the complete image but since it using shadow
tiles it has no chance to change non-selected pixels. Believe me ;-)
Comment 4 Maurits Rijk 2003-05-25 18:52:17 UTC
I believe you :) But actually using the results of
gimp_drawable_mask_bounds will make it at least a bit faster in some
case. This plug-in is terribly slow.
Comment 5 Sven Neumann 2003-05-27 16:45:21 UTC
Yes, that would be a useful optimization. I would also suggest to
change the default so the plug-in does not create a new image.
Creating a new image is rather uncommon for a filter and perhaps the
feature should even be completly removed.
Comment 6 Maurits Rijk 2003-05-27 21:10:58 UTC
I'm also in favor of removing the option to create a new image, so we
get more uniform behaviour amongst plug-ins.
Comment 7 Sven Neumann 2003-05-30 12:58:57 UTC
2003-05-30  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lic.c: removed the possibility to let the
	plug-in create a new image (see bug #113615).

I am changing the bug-report to an enhancement request now. The
plug-in could indeed be a lot faster if it respected the selection.
Comment 8 Tomas Mraz 2003-07-24 13:38:14 UTC
Changing summary to reflect that this is a performance bug.
Comment 9 Erik Johansson 2003-07-24 15:57:32 UTC
Changing target milestone to Future in response to mail from David
Neary on the gimp-developer list.
Comment 10 Florian TRAVERSE 2004-08-10 05:57:33 UTC
Created attachment 30386 [details]
gimp plugin jpeg2000 0.1.1

My first make dist of my first C plugin of gimp, now working with 2.0.x,
opening jpeg2000 images. needs jasper to compile and work.
Comment 11 Florian TRAVERSE 2004-08-10 05:59:38 UTC
hey! what's that!!!! I've attached this file to the 111409 bug,not this one!!! ???

Sorry for the convenience
Comment 12 Thierry Moisan 2005-08-02 20:59:27 UTC
What is going with this? Has it been commited? Can this bug be closed?
Comment 13 Michael Schumacher 2005-08-02 21:05:13 UTC
There hasn't been a patch attached yet...
Comment 14 Karine Delvare 2006-03-17 15:39:06 UTC
Created attachment 61445 [details] [review]
Compute only on the selection

This should fix the performance problem.
Comment 15 Sven Neumann 2006-03-17 15:41:49 UTC
Very nice. Thanks a lot. I have committed this to the HEAD branch.

2006-03-17  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/lic.c: applied a patch from Karine Delvare that
	fixes a performance problem in the Van Gogh plug-in (bug #113615).