GNOME Bugzilla – Bug 113615
Van Gogh plug-in ignores selection [perf]
Last modified: 2006-03-17 15:43:35 UTC
The Van Gogh plug-in always operates on the complete image, ignoring the current selection.
The plug-in does respect the selection unless you ask it to create a new image.
I doubt it (after quick scan of code), since the results of gimp_drawable_mask_bounds are never used.
The plug-in may work on the complete image but since it using shadow tiles it has no chance to change non-selected pixels. Believe me ;-)
I believe you :) But actually using the results of gimp_drawable_mask_bounds will make it at least a bit faster in some case. This plug-in is terribly slow.
Yes, that would be a useful optimization. I would also suggest to change the default so the plug-in does not create a new image. Creating a new image is rather uncommon for a filter and perhaps the feature should even be completly removed.
I'm also in favor of removing the option to create a new image, so we get more uniform behaviour amongst plug-ins.
2003-05-30 Sven Neumann <sven@gimp.org> * plug-ins/common/lic.c: removed the possibility to let the plug-in create a new image (see bug #113615). I am changing the bug-report to an enhancement request now. The plug-in could indeed be a lot faster if it respected the selection.
Changing summary to reflect that this is a performance bug.
Changing target milestone to Future in response to mail from David Neary on the gimp-developer list.
Created attachment 30386 [details] gimp plugin jpeg2000 0.1.1 My first make dist of my first C plugin of gimp, now working with 2.0.x, opening jpeg2000 images. needs jasper to compile and work.
hey! what's that!!!! I've attached this file to the 111409 bug,not this one!!! ??? Sorry for the convenience
What is going with this? Has it been commited? Can this bug be closed?
There hasn't been a patch attached yet...
Created attachment 61445 [details] [review] Compute only on the selection This should fix the performance problem.
Very nice. Thanks a lot. I have committed this to the HEAD branch. 2006-03-17 Sven Neumann <sven@gimp.org> * plug-ins/common/lic.c: applied a patch from Karine Delvare that fixes a performance problem in the Van Gogh plug-in (bug #113615).