GNOME Bugzilla – Bug 113052
Colour preferences not useful/not needed?
Last modified: 2004-12-22 21:47:04 UTC
Can we not change the whole "colors" preference section to be just "Always use theme colours"[1] and come up with a sensible mapping onto the GTK theme? [1] Is this what "Use system colours" is supposed to do?
The only color prefs that are needed for a11y are "Use system colors" and "always use these colors." If would be nice to always default to both of these, however this would break alot of web pages. I suggest removing the fine grain color prefs altogether, defaulting mozilla to always "use the system colors" (ie gtk theme) and than s/"always use these colors"/"Always use desktop theme colors."
Created attachment 16554 [details] [review] ok so this patch does what is stated above. ok to commit?
I'm just a bit unsure on how things will look using gtk colors by default. I'd prefer to browse with it for a bit before ;)
I get an error trying to apply the patch? If I try to make the changes by hand I end up with white text on a gray background which isn't what I'd expect (Given that all my GTK widgets are black on pale blue). My guess is I've missed a bit of the patch. For reference it falls over trying to patch prefs-dialog.c: > patch: **** malformed patch at line 439: Index: src/prefs-dialog.c
I got that same error and made another diff, and it was exactly the same, not sure what is causing the error :/ Marco, i guess i know you said it was ok to commit, but maybe i'll wait till you give it a try first.
Dave, I cant try it because it doesnt apply. Using the same pref in mozilla seem to be fine to me though ... (hoping people dont complain to not have white/black)
How much variance is there in the GTK colours? Basically, the default page background colour is not common to see these days. Yahoo has it... but no other major website I have found uses it. And in almost all cases, the page doesn't really work without a light grey or white background anyway. Basically, I think this preference used to be useful on the web, but now virtually all websites have a background colour set.... The foreground colour I'd be more worried about (because it will affect more web pages), but if its being used throughout GNOME, I guess you can stand whatever colour the theme picked or you'll just switch themes ;-) My feeling is that this preference was something that used to actually changed the web browsing experience, but doesn't very much anymore. So as long as the GTK background colour set for most themes is decent (preferably white or very light grey), I think this is a good change. Link colour is a separate issue and I'd have to think more about that.
seth, as far as link color is concerned. Isn't it better that we push that into an rc file, so that a11y themes can set the link colors and the pref will permeate to all apps that have links (gaim, gtkhtml1,2,3 etc). Isn't this better than forcing a11y theme users to manually set these colors in all apps that have links? What i was thinking was that we could add a special rc file property gnome_visited_link, gnome_unvisited_link, and than we could manually set the colors based on these prefs and monitor for changes. Alternatively we could move these into gtk, which might actually be necessary with the new gtkabout api, but for 2.2 the above idea is probably better. Ijust think have visible prefs here for something that ought to work automagically is a little odd.
<daveb> seth how about adding a special rc file field for link colors that all gnome apps could use <seth> daveb: maybe.... <seth> daveb: But honestly, I'm not sure where to put this in GNOME prefs <daveb> seth make it a theme property <daveb> so that the a11y themes can set it * seth shrugs <daveb> we already do that for nautilus and the icon container text background <seth> I doubt that its a substantial a11y issue, no matter what billh says <seth> Red/Blue colourblindness is not one of the major types of colourblindness <seth> And being able to differentiate between links visited and new links isn't that important really <daveb> seth well other than the a11y issue, is there a usability issue? <seth> Not really <daveb> is there any reason to believe a pref is "necessary"? should we worry about user complaining (real users, not crack heads obviously)? <seth> Well, every user is a real user, we just care about percentages <seth> But ... <daveb> you know what i mean <daveb> :) <seth> I can't think of an important reason to have this preference <seth> In fact, I can hardly think of an instance where I know of somebody changing it <daveb> yeah me either <seth> So its probably just something that's been around since forever <daveb> marco was concerned about grey backgrounds <seth> And nobody's thought twice about it <seth> Grey backgrounds? <daveb> nod <seth> They *are* lower res <seth> s/res/contrast/ <seth> But presumably if you're poor sighted you won't be using a theme with a grey bg <-- sri has quit (RRRrrrrrrrr...pfft.) <seth> Plus NS4 used to be grey anyway <daveb> seth not from a11y but from users use to white <seth> So its probably what many of the sites that don't set bg "expect" anyway <seth> daveb: Try to find a site that doesn't set BG <seth> daveb: I happened to know that yahoo doesn't from the old days <daveb> seth i know its hard, i tried <seth> But... had NS4 not used grey (which I hated ;-) I wouldn't have known <seth> And I think I only changed it for Yahoo <seth> So... I don't think its a major issue <daveb> yeah, plus most people use google now :) <seth> It should be whatever colour text-box backgrounds etc are <daveb> yeah <daveb> thats what moz does <seth> So if the person can stand those being wanked out <daveb> ok i'm going to copy and paste this into the bug and wait for final approval from marco ************************************************* marco final decision?
Let's get it in ;)
fixed in cvs.