GNOME Bugzilla – Bug 112851
Window button order needs to match HIG
Last modified: 2004-12-22 21:47:04 UTC
The buttons along the bottom of the Settings dialog are currently very un-HIG like. Am attaching a patch to rectify this (ideally needs testing against earlier versions of gtk to make sure it doesn't break, though).
Created attachment 16465 [details] [review] Patch for HIGification of settings dialog buttons
I'm also working on a patch to HIGify the rest of this dialog which will include the above patch, so probably safer to wait until I've finished that before considering this one too hard :)
Ok, here's a patch that does about all you can do in the Glade file to HIGify the settings dialog... the main remaining job is the dynamic bit in the middle of the Access Methods tab, which is concocted in the code rather than in Glade so is going to be a pit of a pain to sort out :/ It also changes the title to Preferences, as per bug #112852.
Created attachment 16474 [details] [review] Expanded patch to HIGify most of the rest of the settings dialog
Note these changes do make an already large dialog slightly bigger still, so we might want to shave a few pixels off the HIG-recommended spacings here and there. Although it might also point to the requirement for a more fundamental redesign further down the road, it is a pretty scary window :)
Calum, I have perused the diff and applied the patch. I had a look at the settings dialog. Looks Higified to me -- Thanks! It is still monstrous yes, but historically, the most popular on-screen keyboards have had monstrous dialogs with many many settings. e.g. WiViK (for windoze) The jury is still out on the actions page preceding the access methods page. We'll have to get some more clinical feedback I think. As far as I have tested, your patch doesn't break anything so please apply. Thanks again, and any continued efforts to improve gok's preferences is much appreciated!
Thanks, committed. I'll close this bug since it was really just about the button order, and open another one to cover the non-HIGgy parts of the Access Methods tab that will need fixing in the code when somebody's feeling brave enough :)