After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112607 - [0.6.2] fails to build gstgetbits_i386.s on Solaris x86 w/o gas
[0.6.2] fails to build gstgetbits_i386.s on Solaris x86 w/o gas
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.6.x
Other opensolaris
: Normal normal
: 0.6.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-05-09 00:49 UTC by Hidetoshi Tajima
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch to use generic .align 16 instead of gas-local .p2allign 4,7. (1.39 KB, patch)
2003-05-09 00:52 UTC, Hidetoshi Tajima 		none Details | Review

Description Hidetoshi Tajima 2003-05-09 00:49:04 UTC 
Using TBRANCH-GSTREAMER-0_6 of gstreamer, gstreamer build fails on a
Soalris x86 where no GNU assember(gas) is installed.

% cc -O -I/usr/include -I/gnome/head/INSTALL/include -I/usr/sfw/include -c
gstgetbits_i386.s  -KPIC -DPIC -o gstgetbits_i386.o
Assembler:
        "gstgetbits_i386.s", line 1 : Illegal mnemonic
        "gstgetbits_i386.s", line 1 : Syntax error
        "gstgetbits_i386.s", line 27 : Illegal mnemonic
        "gstgetbits_i386.s", line 27 : Syntax error
        "gstgetbits_i386.s", line 48 : Illegal mnemonic
        "gstgetbits_i386.s", line 48 : Syntax error
        "gstgetbits_i386.s", line 65 : Illegal mnemonic
        "gstgetbits_i386.s", line 65 : Syntax error
        "gstgetbits_i386.s", line 87 : Illegal mnemonic
        "gstgetbits_i386.s", line 87 : Syntax error
        "gstgetbits_i386.s", line 102 : Illegal mnemonic
        "gstgetbits_i386.s", line 102 : Syntax error
cc: assembler failed for gstgetbits_i386.s
make: *** [gstgetbits_i386.lo] Error 1

This can be avoided by s/.p2align 4,,7/.align 16/g.

I'll attach a sample patch. Perhaps, it would be
better to add HAVE_GNU_AS configure check to
decide which of .p2align or .aligh can be used.
Comment 1 Hidetoshi Tajima 2003-05-09 00:52:29 UTC 
Created attachment 16378 [details] [review]
a patch to use generic .align 16 instead of  gas-local .p2allign 4,7.
Comment 2 David Schleef 2003-05-09 18:45:50 UTC 
Applied to HEAD.

.align 16 is almost always more correct than .palign 4,,7 in speed
critical code (on i386, blah, blah, add lots of qualifiers here.)
So I don't see a need to detect if gas can handle .p2align -- we
should just use .align.
Comment 3 Ronald Bultje 2003-05-09 21:48:46 UTC 
Don't close yet, we need this in 0.6.2 too!
Comment 4 David Schleef 2003-05-10 22:03:57 UTC 
Duh, sorry.  I applied it to 0.6.x, too.
Comment 5 Christian Fredrik Kalager Schaller 2003-05-12 14:48:44 UTC 
Since it is applied so am I closing this.