GNOME Bugzilla – Bug 112571
The cleared mines are similar to the uncleared in some themes.
Last modified: 2014-05-07 01:20:30 UTC
The cleared mines backgroung is the same as the color of the uncleared mines, so is very dificult to see clearly which parts are cleared. See the atached screenshot. One solution may be let choose colors or use a fixed way of rendering the mine boxes, without following the theme selected by the user.
Created attachment 16363 [details] Screenshot of the problem
I think I've been told that this is a bug in the theme, but I'm not entirely sure on that. It certainly looks bad here, using the default theme on Red Hat Linux 9.
Its probably not a theme bug. If I recall correctly the colours for the numbers are hard-coded into gnomine. Since a theme can legitimately choose any background colour it likes there is always the possibility for conflict. One solution might be to try and automatically generate the colours to be high-contrast with respect to the background. It may be straightforward to have two contrasting colours for each number and to just dump any colours which are "too close" to the background. The problem here is deciding what is "too close". I suspect that even if it generally worked there would be pathological cases. The other disadvantage is that people get used to the colours meaning a particular number. The alternative may be to just put our own background in, like painting the number on a white dot or something (the dot doesn't have to be high-contrast with the background, although adding a black border would be possible). This has the problem that it will look crowded when the tile size is too small. I don't like the idea of overriding the background completely. If the theme could give us a bigger set of colours we could get them out of the theme, but for the moment the API only gives us the standard GTK colours.
The problem is not the colours of the numbers, but the diference between the buttons of the mines, the ones cleared and the ones uncleared. I'll love to see the original 3D buttons, even if my theme's buttons are plain. Is not the same the way I want normal buttons and a matrix of small buttons. Maybe should be an option to render the buttons with a default theme, without using your settings.
Yeah, I know I got it wrong when I read it the first time (not enough sleep). Both problems are bugs. You'll be pleased to know that your complaint has now been fixed in CVS (should be ready in 2.3.2). This was achieved using the suggestion in bug 97732: using a dotted line for the uncovered mines. This works for all the themes that are shipped with GNOME, some of them were just as bad as your example. If you still aren't satisfied when the new release comes out complain again and tell me what theme you're using. I'm keeping this bug open to remind me of the colour issue.
Thanks a lot! I'll test it!
*** Bug 126141 has been marked as a duplicate of this bug. ***
Whoops. I filed a new bug before realizing this bug existed. I still personally think this is a problem in GNOME 2.4 in some themes. Is there a way we could differentiate more between cleared and uncleared squares? My suggestion in bug 126141 was to get rid of the stippled line around cleared squares, leaving no border at all.
Actually you should have marked it as a duplicate of bug #122969 :). The drawing code has been rewritten in 2.5.0 to make more use of the theme colours and drawing engine. So it should look better across all themes. Unfortunately these changes are not thoroughly tested enough to back-port to 2.4.x. Download 2.5.0 or the CVS version of gnome-games to see the new stuff and look at bug #122969 for additional comments.
Should this be closed as "Fixed in 2.6.x"?
I think the spirit of the bug is still open, see: http://mail.gnome.org/archives/games-list/2004-September/msg00010.html
Technically the original complaint was fixed, and this was kept here as a reminder that I have yet to make sure the *numbers* are visible when viewed against, say, a dark background. See comment #3 (and #5 where I explain that #3 is misinterpreting the screenshot and seeing a different bug to the one reported). As Richard points out, soe themes still cause trouble. I have fixed some of them, but others have not been. I am almost at the point of calling the remaining themes buggy, but I'm not confident enough that they are doing something wrong yet.
Finally, a good example.... Let's all go look at this page: https://launchpad.net/distros/ubuntu/+source/gnome-games/+bug/48371 At this screenshot: http://librarian.launchpad.net/3023840/Kubuntu_Dapper_Gmines_DefaultStyle.png (Kubuntu Default theme? I don't kmow....) Time to decide if it's our problem or a theme problem, then close this bug. :)
What if we reuse the code from http://david.navi.cx/blog/?p=94 ? For both the text color AND the covered mines?
Created attachment 162489 [details] screenshot from Ubuntu 10.04 Here is the default theme in Ubuntu 10.04. Although it is possible to see the difference between blank and undiscovered squares, the contrast is not very good. The vertical gradients makes it worse I think.
Created attachment 162490 [details] screenshot from competition For a comparison, this is what it looks like on my mobile phone. I like this much better. You really get the feeling you are uncovering spots on a background field, with tiles being removed as you advance.
See bug 664981 for updating the artwork
Has there been any progress on this? I think this is separate from updating the artwork, as this has to do with changing the colors of the numbers.
Unfortunately nothing has been implemented, but we do have a design (posted at the bottom of Bug #664981) that addresses this issue.
Bug 728483 contains lots of relevant changes, and the head already contains the fixes with custom CSS styling, meaning that the flipped and non-flipped tiles have distinct colors.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.