After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112433 - indic-fc.c: Wrong properties used for GPOS
indic-fc.c: Wrong properties used for GPOS
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: Owen Taylor
Owen Taylor
Depends on:
Blocks:
 
 
Reported: 2003-05-06 19:47 UTC by Owen Taylor
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (against head) (2.10 KB, patch)
2003-05-28 20:29 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2003-05-06 19:47:42 UTC 
In indic_engine_shape(), we pass the same 'tags' array to
both calls to pango_ot_ruleset_shape(), however since the
first call has changed the set of glyphs, the tags array
is no longer correct for the second call, and even
(in the case of inserted glyphs) might be too short for
the glyph array.

Probably the right solution here is to optionally modify 
indic_engine_shape() so that it returns a new array which
is the properties as rearranged by the substitution
procedure.

A fix could be made here without changing the indic-ot.h
interfaces (changing them in the 1.2 branch is a little
bad), by using log_clusters[] as described in the note in
the comments for bug 111166.
Comment 1 Owen Taylor 2003-05-28 20:29:31 UTC 
Created attachment 16920 [details] [review]
Proposed patch (against head)
Comment 2 Owen Taylor 2003-05-28 20:30:49 UTC 
I've attached a patch that I believe should fix the
problem ... it works for me in *very* limited testing.
(Some Devanagari examples still display, apparently correctly,
without crashing.)
Comment 3 Owen Taylor 2003-05-29 22:58:35 UTC 
I've applied my patch, we'll hope that nothing breaks.

Thu May 29 18:49:00 2003  Owen Taylor  <otaylor@redhat.com>
                                                                     
          
        * modules/indic/indic-{xft,ft2}.c: Use the correct tags at
        the GPOS stage, taking into account changes during
        the GSUB stage. (#112433)
Comment 4 Owen Taylor 2003-07-24 21:58:02 UTC 
Turned out that I never committed this to HEAD; fixed now.