After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 112014 - [PATCH] quality min/max for vorbisenc are incorrect
[PATCH] quality min/max for vorbisenc are incorrect
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.6.1
Other Linux
: Normal trivial
: 0.6.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-05-01 18:38 UTC by Marinus Schraal
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vorbisenc min/max correction (806 bytes, patch)
2003-05-01 18:39 UTC, Marinus Schraal
none Details | Review

Description Marinus Schraal 2003-05-01 18:38:39 UTC
The vorbisenc plugin sets -1 to 10 as possible quality settings for the
quality parameter, while it really ranges from 0 to 1 (float).
Comment 1 Marinus Schraal 2003-05-01 18:39:37 UTC
Created attachment 16177 [details] [review]
vorbisenc min/max correction
Comment 2 Benjamin Otte (Company) 2003-05-02 16:25:59 UTC
Some things:
- vorbisenc allows to set values < 0 to use managed bitrate, that
should still be allowed.
- oggenc (the program) uses a quality from 0 to 10 with a default of
3. Wouldn't it make more sense to simply divide by 10 when calling
vorbis_encode_init_vbr? (Would require updating the default value from
0.3 to 3)
Comment 3 Marinus Schraal 2003-05-02 16:52:08 UTC
it looks like negative values are only determining if a quality is
set, you can just as well check if a valid quality is set to do that.

what oggenc does is not really relevant, i think it would be best to
just follow the library specs.

This error seems to come from the fact that parts of the vorbisenc
seemed to be copied from oggenc.
Comment 4 Christian Fredrik Kalager Schaller 2003-07-23 11:45:50 UTC
Assigning back to gstreamer-maint, not sure why it was assigned to me :)

Benjamin do you still have objections to this patch?
Comment 5 Christian Fredrik Kalager Schaller 2003-07-23 19:15:04 UTC
Patch applied to 0.6 CVS after being reviewed by ds. Tried applying to
head by was told that patch is already applied there. Closing this
bug. Thanks foser