GNOME Bugzilla – Bug 110832
[0.6.2] make avimux caps nego slightly better
Last modified: 2004-12-22 21:47:04 UTC
If the layer (2 or 3) is not indicated for an audio/x-mp3 stream the avimux prints some cryptic warnings. This patch makes it easier to understand what is going wrong.
Created attachment 15731 [details] [review] proposed patch
Minor nitpicking: I think we want to assume mp3 by default. Reason is that most mp3 decoders can decode mp2 just fine, while the reverse is less often true. Apart from this - well noticed, thanks!
Assigning to Ronald for review/small change/commit
I've applied the patch to HEAD CVS (well, that was actually an accident, but ohwell). http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/gstreamer/gst-plugins/gst/avi/gstavimux.c.diff?r1=1.32&r2=1.33 We probably want this in 0.6.2 too, so marking for that.
this will take too long. We'll see about this later. Testing first.
HEAD now has a slightly improved AVI muxer. It's not 100% yet, but it should do common things well now. We might want to backport it to 0.6.x fully, although it uses some features not present there (the GstBuffer duration field, for example).
I've got the rest of this in my caps remake. *** This bug has been marked as a duplicate of 116387 ***