GNOME Bugzilla – Bug 110786
Opening pages in a new tab
Last modified: 2004-12-22 21:47:04 UTC
The option to open in tabs by default is not sufficient for general use, as this is not always desireable. it would be cool to have the mozilla feature where clicking on a link whilst pressing ctrl would open said link in a new tab.
I pretty much agree with this though I'm not sure if ctrl or alt should be used.
Barring a good reason to diverge from Mozilla's behavior, I'd say Ctrl is preferred. I'm attaching a patch against 0.8.2 that implements this. Because it conflicts with a patch I submitted in bug 116809, this patch includes both changes.
Created attachment 19294 [details] [review] handle Ctrl-click the same as middle click
Marco, can this go in now?
On head we open in new tab by default on middle click. I'd prolly just make ctrl+click behave the same as middle click. (for now at least, not sure if it will be necessary to have a pref or something to use a window).
Created attachment 21163 [details] [review] patch updated to HEAD
The patch now implements: - ctrl+click open in new tab - shift+click on link -> save - shift+click on non-link image -> save image One thing I noticed is that we have variants of save_property_url in window-commands:window_cmd_file_save_as, ephy-embed-popup-control.c:save_property_url, popup-commands.c:save_property_url and now in ephy-tab.c:save_property_url... it might be worth factoring that out to one function.
Created attachment 21175 [details] [review] better patch
Much better :) please use 2000-2003 in the license thing. Please commit, thanks ! (oh do not forget to add the doc thingy)
Created attachment 21179 [details] [review] final patch
I had to change back to one-level ifs because the previous patch was _not_ equivalent to the current code; for example middle clicking over a non-link image wouldn't have worked anymore. To make it more readable, I introduced some mode boolean vars. As for the docs, I'll add a "Things to document" file in help/. Ok to commit?
Created attachment 21180 [details] [review] fixed a typo
The middle_clickable thing isnt exactly clear :/ Though I think it's ok to commit. We can fix it up later if we get better idea. Thanks!
Got finally around to checking this in.