After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 110681 - deleting a topic from bookmarks
deleting a topic from bookmarks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
0.x
Other Linux
: Normal normal
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
: 111183 (view as bug list)
Depends on:
Blocks: 110664
 
 
Reported: 2003-04-13 16:38 UTC by Alex Duggan
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alex Duggan 2003-04-13 16:38:56 UTC
Deleting a topic from the topics list of the bookmark editor causes ephy to
hang for about 10-15 seconds and pegs the CPU at 100%.
Comment 1 Xan Lopez 2003-04-14 16:59:36 UTC
A few things about this.
The remove topic code is not slow per se, the problem is that we
select All after doing the removal, and it's selecting All what is slow :)
In my box selecting All with ~250 nodes takes about 3 seconds (1,4Ghz
box), which is clearly too slow.
After doing lots of profiling and going crazy about this, I asked kris
about it and it resulted that it was a gtk+ bug after all: 
"Massive inefficiency in gtk_tree_model_sort_level_find_insert()"
http://bugzilla.gnome.org/show_bug.cgi?id=109292
With that patch applied to gtk+, you'll enter in a new world of
extreme performance.
So now the question is, while we wait for this to land in gtk+ (it
will go to HEAD, but kris is afraid of backport to 2.2.x, as the
GtkTreeModelSort is very fragile), what do we do?
There is a huge and messy workaround for this in Rhythmbox, but I
think the best approach is simply don't select anything after topic
removal (of course this does not fix the fact that selecting All is
still a pain, but I think it's worth to wait fot the gtk+ fix).
What do you say Marco?
Comment 2 Xan Lopez 2003-04-16 09:34:00 UTC
I implemented a workaround for this in cvs. Now, before removing a
node we select the next node in the view, the previous one if it was
the last one, and nothing (All) if it was alone. I think this makes
impossible to select All when deleting a topic (Most Visited and Not
Categorized, which can't be removed) are after it), so I'm closing as
fixed.
Comment 3 Marco Pesenti Gritti 2003-04-20 08:40:35 UTC
*** Bug 111183 has been marked as a duplicate of this bug. ***