GNOME Bugzilla – Bug 110213
no bindtextdomain call is made
Last modified: 2004-12-22 21:47:04 UTC
It does not seem libgnomevfs or any of modules(file, ftp,http, vfolder..) calls bindtextdomain(), so they are not bound to gnome-vfs-2.0, a message file for gnome-vfs-2.0. As a result, none of the translation is used in gnome-vfs-2.0.
bindtextdomain() should be called in gnome_vfs_init() in library, and in each vfs_module_init() which should have translable messages. will attach a patch after this comment.
Created attachment 15545 [details] [review] call bindtextdomain whereever _("foo") is actually used
Please review the patch and commit if it looks okay. Also, po/POTFILES.in po/POTFLES.skip may need to change.
bindtextdomain should be called inside #ifdef ENABLE_NLS. Why do the modules need to call anything? They use the same translation domain as the main library, and that is guaranteed to be initialized before the modules.
Yes, I oversited gnome_vfs_init() is called for the modules. will create a new patch attachment.
Created attachment 15618 [details] [review] gnome_vfs_init() should call bindtextdomain inside #ifdef ENABLE_NLS.
looks fine to commit.
Thanks, commit to the HEAD. * libgnomevfs/gnome-vfs-init.c (gnome_vfs_init): call bindtextdomain inside #ifdef ENABLE_NLS. Fixes bug #110213.
If it results in strings visible in the GUI which aren't translated, can you also commit to the gnome-2-2 branch ?
commit to gnome-2-2 branch, too. GUI strings on a gnome-vfs module cannot be translated without this. Bug 103306 is an example of CDE menu.
Did you tell gnome-i18n-list of this string change?
(If indeed there were any string changes..)
Doesn't seem to be any string changes -- the patch only affects what is displayed at runtime, not what messages are extracted from source.