After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 110014 - Display problems with selection border and image border
Display problems with selection border and image border
Status: VERIFIED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other Linux
: Normal minor
: ---
Assigned To: GIMP Bugs
Daniel Egger
Depends on:
Blocks:
 
 
Reported: 2003-04-04 21:53 UTC by Pedro Gimeno
Modified: 2009-08-15 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to work around the selection lines problem. (2.69 KB, patch)
2003-04-04 21:56 UTC, Pedro Gimeno 		none Details | Review
Further fixes to the same problem, this time when dragging the selection (1.04 KB, patch)
2003-04-06 22:50 UTC, Pedro Gimeno 		none Details | Review

Description Pedro Gimeno 2003-04-04 21:53:34 UTC 
Under certain circumstances, the border of the selection is wrong. It also
happens to the image border.

How to reproduce:

 1. Create a 10x4000 RGB image.
 2. Select all.
 3. Shrink selection by 1 pixel.
 4. Zoom to 9:1.
 5. Scroll to the top of the image.

Both lines show strange behaviours now.

Additional comments:

Seems to be a GDK (or X) problem that shows up when the size of the line to
be drawn is beyond 32767 pixels. It can be easily worked around; the
following patch solves both issues.
Comment 1 Pedro Gimeno 2003-04-04 21:56:32 UTC 
Created attachment 15485 [details] [review]
Patch to work around the selection lines problem.
Comment 2 Sven Neumann 2003-04-04 22:33:19 UTC 
2003-04-05  Sven Neumann  <sven@gimp.org>

   * app/display/gimpdisplayshell-selection.c: applied a patch from
   Pedro Gimeno that fixes incorrect drawing of the selection border
   caused by overflowing 16bit X coordinates (bug #110014).
Comment 3 Pedro Gimeno 2003-04-06 22:50:02 UTC 
Created attachment 15518 [details] [review]
Further fixes to the same problem, this time when dragging the selection
Comment 4 Sven Neumann 2003-04-07 16:30:42 UTC 
2003-04-07  Sven Neumann  <sven@gimp.org>

  * app/tools/gimpeditselectiontool.c (selection_transform_segs):
  another patch from Pedro Gimeno that addresses problems displaying
  the selection border (bug #110014).
Comment 5 Pedro Gimeno 2003-05-25 23:57:13 UTC 
Fix merged into STABLE:

2003-05-26  Pedro Gimeno

	* app/selection.c (selection_transform_segs)
	* app/edit_selection.c (selection_transform_segs,
	edit_selection_draw): Merged last bit of the fix for bug #17904
	from HEAD. Also merged fix for bug #110014.

	* app/rect_select.c (rect_select_draw): Added more clampings to
	avoid 16-bit overflows like those in bug #110014.

The fix to HEAD has been also improved to handle a previously
unhandled case (selection spilling off the layer limit):

2003-05-26  Pedro Gimeno

	* app/display/gimpdisplayshell-selection.c
	(selection_transform_segs): Perform the clamping that fixes
	bug #110014 here instead of in the callers. Solves a rare case
	that was not properly handled before.
	(selection_render_points, selection_generate_segs): Remove the
	clamping code from here.

	* app/tools/gimpdrawtool.c (gimp_draw_tool_draw_rectangle): More
	clampings to avoid overflow of 16-bit coordinates.
Comment 6 Raphaël Quinet 2003-06-20 20:23:16 UTC 
The fix is part of the stable release 1.2.5.  Closing this bug.