startrek future :/

What does the HIG say about Print preview?

I think the HIG suggest more or less what Dave was saying. The problem
is that I dont think it's possible to implement it with current
mozilla api.

/me thought about this a little....

No idea if this is even possible, but can we make print preview a 
toggle menu entry in the file or view menu (the proper menu isn't 
clear to me in this case, though generally the hig recommends file), 
and keep the menubar when in print preview mode (perhaps just disable 
some menu items)? Not as good as opening in a new window, but light 
years ahead of what we have now :/

Yeah that can be done. The idea is nice, what worries me is that it's
very unusual :/

Yeah its unusuall, but at least clearer than what we got now. Don't 
get me wrong I'd still prefer poping up a new window, but i'm being 
realistic here :)

this is actually pretty easy to do, the only issue is that i think the
print_dialog code in embed will need to be refactored.

One problem could be that mozilla need the page loading to be finished
before ppv works. Not sure how that would interact with cloning.

Assigning to new "Printing" component.

Changing summary to reflect chpe's printing reorganisation.

Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o

IMHO, there's somes problems with the current behaviour :

1) You cannot print from the print preview (! he !)
2) You don't want to click on "Close" because you think "Hey, I don't want to
close all my epiphany window !"

Open a new window is not very good, I would prefer a new tab, not very sure, but
it can be discuted.

For now, I think a temporary solution would be :

- add a "print" icon
- rename the "close" button to "back to browser" or something like that.  It
would help a lot new users.

I am always amazed when clicking the print preview's window close button also
closes the page I was previously viewing.

If the print preview is not in a separate window, the very least that I would
hope for is to make it obvious how to return to the normal screen rendering of
the page.  For me, the more natural button for this purpose would actually be
the back button.

*** Bug 309820 has been marked as a duplicate of this bug. ***

From bug 309820: 

Once evince is an official part of the GNOME desktop, we should use it as the
primary print preview interface.

This may be dependent on Mozilla using cairo as print back-end.

.

See also http://live.gnome.org/Epiphany_2fFeatureDesign_2fPrintPreviewDoneRight

OK, summarizing:

Comment#0: [Done] Under “File” now.

Comment#12:
  1) is still to be addressed (printing from the preview)
  2) is almost addressed (the button tooltip is “Close the print preview”).

I'm thinking that we could either use toolbar preferences (“Text below icons”, “Icons only”, and the like), or force the display of at least the text of the “Close the print preview”, so that no-one gets confused about the action one is about to trigger. Thoughts?

1) and the "do ppv in new window" itself are impossible currently due to gecko backend limitations.

Forcing the close toolbar button to show its text is fine with me (I think you need to set the "is-important" (and maybe the "short-label") properties on toolbar items.

Created attachment 95207 [details] [review]
Add labels to the printpreview toolbar button(s)

It is also possible to only show the text for the Close icon, by replacing GTK_TOOLBAR_BOTH with GTK_TOOLBAR_BOTH_HORIZ; I have no preferences, and I'm not the maintainer. ;-)

One could also think of using the *_get_widget() function to avoid having to use action+action_group, but then, the set of interesting properties (“is-important”, “short-label”) is no longer available.

I forgot to mention that one could think of using a shorter label (as you actually proposed), like “Close preview”, which would maybe make more acceptable the idea of putting all labels, using GTK_TOOLBAR_BOTH. That might be an unneeded burden for translators, though.

Thanks for the patch!

+	action_group = t->priv->action_group;
+	action = gtk_action_group_get_action (action_group, "PPVClose");

No need for a local variable you just use once; just use t->priv->action_group directly.

+	g_object_set (G_OBJECT (action),

This cast is unnecessary.

+	widget = gtk_ui_manager_get_widget (t->priv->manager,
+					    "/PPViewToolbar");
+	gtk_toolbar_set_style (GTK_TOOLBAR (widget), GTK_TOOLBAR_BOTH);

I don't think we should force BOTH here since that mode is ugly; and it conflicts with the user's choice in the Appearance capplet.
If the mode is already BOTH, BOTH_HORIZ or TEXT_ONLY, everything is fine.
In case the mode is icons-only we could force BOTH_HORIZ but not BOTH.

Created attachment 95230 [details] [review]
Printpreview patch update

Fixed first items. And adapted the toolbar style as you wished. (I've no Appearance applet to test it thoroughly, though.)

Thanks! oktc, trunk only.

In gnome 2.18 it's in the Menu&Toolbars control centre applet.

Committed to r7363.
Should we close this bug?

No, let's keep it open since the original problem from comment 0 isn't fixed. It depends on gecko changes though.

This appears to be resolved in 2.29.92:

 * print preview is in the file menu
 * print preview appears in a separate window

Indeed. Thanks Sam!