GNOME Bugzilla – Bug 108101
Header guards
Last modified: 2005-08-22 20:22:38 UTC
I'm not sure about badhack.h, but the others look real. ~/private/gnome/libegg> perl ../gnumeric/tools/check-header-guards ../gnumeric/tools/check-header-guards: File `libegg/recent-files/egg-recent.h' is not guarded. ../gnumeric/tools/check-header-guards: File `libegg/toolbar/prop-editor.h' is not guarded. ../gnumeric/tools/check-header-guards: File `libegg/combo/badhack.h' is not guarded. ../gnumeric/tools/check-header-guards: Files `libegg/combo/eggtreemodelfilter.h' and libegg/treeviewutils/eggtreemodelfilter.h have same guard.
badhack.h is not guarded because it is a bad hack (SURPRISE!) and is only there temporarily. Both eggtreemodelfilter.h files have the same guard, because they are about the same. I should merge the changes there one day (prolly soonish). So I will take care of the eggtreemodelfilter one, James will bug the others for the rest, right James? (: I removed the GNOMEVER2.2 keyword, because that doesn't make any sense here (remember, libegg is an *unstable* playground).
egg-recent.h is not guarded because it's only a convenience header.....all the headers it includes are guarded (or should be)...
2005-08-22 Emmanuele Bassi <ebassi@cvs.gnome.org> * libegg/recent-files/egg-recent-model.c: (egg_recent_model_init), (egg_recent_model_poll_timeout), (egg_recent_model_finalize), (egg_recent_model_monitor): If FAM support is unavailable, manually poll the .recently-used file (patch by Dinoop Thomas, fixes bug #140153). * libegg/recent-files/egg-recent-model.c: fixes compilation on Darwin where lockf() isn't exported (patch by Jerry Talkington, fixes bug #124238). * libegg/recent-files/egg-recent-model.c: (egg_recent_model_clear): if FAM is not available, force update of the list when removing an item (patch by Mark McLoughlin, fixes bug #308779). * libegg/recent-files/egg-recent.h: added header guards; this is a convenience header, so you should not use it anyway (fixes bug #108101).