Bug 107910 – crashes when fed with Korean spam.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 107910 - crashes when fed with Korean spam.


Summary:	crashes when fed with Korean spam.


Status:	RESOLVED FIXED

Product:	gtkhtml2
Classification:	Deprecated
Component:	CSS Parser
Version:	2.2.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	padraig.obriain
QA Contact:	Anders Carlsson

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2003-03-09 10:18 UTC by Pawel Salek
Modified:	2004-12-22 21:47 UTC

See Also:
GNOME target:	---
GNOME version:	2.1/2.2

Attachments
gtkhtml2.2-test.html (6.38 KB, text/html) 2003-03-09 10:20 UTC, Pawel Salek		Details
Patch to stop crash (533 bytes, patch) 2003-03-18 15:57 UTC, padraig.obriain	none	Details \| Review

Description Pawel Salek 2003-03-09 10:18:09 UTC

The message printed on the console is:
HtmlCss-ERROR **: support unicode!
 
aborting...
 

The stacktrace is:

+ Trace 34680

#3 g_log
from /usr/lib/libglib-2.0.so.0
#4 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#5 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#6 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#7 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#8 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#9 css_matcher_get_style
from /usr/lib/libgtkhtml-2.so.0
#10 css_parser_parse_stylesheet
from /usr/lib/libgtkhtml-2.so.0
#11 css_value_unref
from /usr/lib/libgtkhtml-2.so.0
#12 css_value_unref
from /usr/lib/libgtkhtml-2.so.0
#13 g_cclosure_marshal_VOID__OBJECT
from /usr/lib/libgobject-2.0.so.0
#14 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#15 g_signal_emit_by_name
from /usr/lib/libgobject-2.0.so.0
#16 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#17 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#18 html_focus_iterator_next_element
from /usr/lib/libgtkhtml-2.so.0
#19 htmlParseEntityRef
from /usr/lib/libxml2.so.2
#20 htmlParseEntityRef
from /usr/lib/libxml2.so.2
#21 htmlFreeParserCtxt
from /usr/lib/libxml2.so.2
#22 htmlParseChunk
from /usr/lib/libxml2.so.2
#23 html_focus_iterator_next_element
from /usr/lib/libgtkhtml-2.so.0
#24 html_stream_close
from /usr/lib/libgtkhtml-2.so.0
#25 html_document_close_stream
from /usr/lib/libgtkhtml-2.so.0


The package is gtkhtml2-2.2.0-4 as distributed with RH/phoebe-3

Comment 1 Pawel Salek 2003-03-09 10:20:01 UTC

Created attachment 14860 [details]
gtkhtml2.2-test.html

Comment 2 padraig.obriain 2003-03-18 15:26:19 UTC

The problem seems to be that gtkhtml2 does not contain code to ,parse
in css_parser_parse_string() what appears to be a Korean font-family
name.

The strings seems to be
"\xc2\xb1\xc2\xbc\xc2\xb8\xc2\xb2",
"\xc2\xb5\xc2\xb8\xc2\xbf\xc3\xb2";

I am not sure that should be done with this string. Any suggestions
welcome.

Comment 3 Pawel Salek 2003-03-18 15:35:38 UTC

I think CSS says that if no requested font can be found, a fall back
font should be used.

I think a HTML renderer is allowed to ignore requests for fonts that
are unavailable or have unparsable names.

IMHO, what is important here is to avoid the crash.

Comment 4 padraig.obriain 2003-03-18 15:57:22 UTC

Created attachment 15098 [details] [review]
Patch to stop crash

Comment 5 padraig.obriain 2003-03-18 15:58:11 UTC

The attached patch attempts to prevent crash. Does this work
adequately?

Comment 6 Pawel Salek 2003-03-18 17:08:02 UTC

Yes it does. Thanks for your work!

Comment 7 padraig.obriain 2003-03-19 08:42:58 UTC

Patch committed to CVS HEAD.