After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107527 - Shift+right should become shift+left in RTL in GtkTreeView
Shift+right should become shift+left in RTL in GtkTreeView
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
AP3
Depends on:
Blocks: 76219
 
 
Reported: 2003-03-04 05:39 UTC by Noah Levitt
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (Aug 17) (1.83 KB, patch)
2003-08-17 16:25 UTC, Kristian Rietveld 		none Details | Review

Description Noah Levitt 2003-03-04 05:39:49 UTC 
The shift+right key combo works the same way in RTL as it does in LTR, and
shift+left does nothing. In RTL, shift+left should do what shift+right does
in LTR.
Comment 1 Calum Benson 2003-04-03 14:25:45 UTC 
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 2 Kristian Rietveld 2003-04-09 17:17:41 UTC 
Will fix before 2.4 comes out.
Comment 3 Calum Benson 2003-08-07 16:09:40 UTC 
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 4 Kristian Rietveld 2003-08-17 16:25:50 UTC 
Created attachment 19288 [details] [review]
patch (Aug 17)
Comment 5 Kristian Rietveld 2003-08-17 16:27:51 UTC 
This should do the trick. Maybe I misused the "logical" parameter,
because I don't know what it is for.

Jonathan should comment on that.
Comment 6 Jonathan Blandford 2003-12-17 23:25:26 UTC 
Eek.  I screwed this up Kris, and got the logical flag backwards.

The 'logical' flag is to indicate that the key press means the action
directly, and has nothing to do with a direction.  So the test in the
code needs to really be:

if (!logical && gtk_widget_get_direction (GTK_WIDGET (tree_view)) ==
GTK_TEXT_DIR_RTL)
   expand = !expand;

Additionally, all the keybindings having to deal with the '+' and '-'
key can be considered 'logical' keybindings.  Those dealing with
arrows should be considered not logical.
Comment 7 Kristian Rietveld 2003-12-18 00:25:14 UTC 
Fixed on HEAD.