GNOME Bugzilla – Bug 107526
GtkScrolledWindow needs RTL support
Last modified: 2011-02-04 16:16:03 UTC
1. As jrb mentioned in the announcement email about tree view RTL, a scrolled window with a horizontal scrollbar expands/contracts/shows/hides (not sure what to call it) the wrong side of the scrolled window. 2. Vertical scrollbars seem to always show up on the right side. Should be on the left in RTL, I think.
I'll attach two patches here. The first is a patch for gtkscrolledwindow.c, which fixes issue 2. The second is a patch for gtkviewport.c which tries to fix issue 1. It is not working perfectly though, someone will have to investigate why it flickers so badly. And, of course, other "scrollable" widgets will have to be individually fixed wrt. issue 1.
Created attachment 16837 [details] [review] gtkscrolledwindow.c patch
Created attachment 16838 [details] [review] gtkviewport.c patch
FYI, the viewport patch no longer applies successfully to HEAD. :-\
Created attachment 18115 [details] [review] viewport.c patch
Another patch for issue 2 is on the following URL. It was created from the source in CVS on 2003/Nov/19 http://www-124.ibm.com/developerworks/oss/linux/patches/?patch_id=1191 Thank you,
Created attachment 21873 [details] [review] Patch for testgtk to reproduce the bug
I'd like to write the steps to reproduce the bug. 1. Apply the testgtk-for_test.20031119.patch to tests/testgtk.c. (The patch is the one I attached in last comment.) The purpose of this is to change direction of 'scrolled windows' dialog at the runtime. 2. Run testgtk in the bidi locale. (e.g. he_IL) 3. Choose item 'scrolled windows'. Initial position of the vertical scroll bar is the right side. <-- Problem 4. Change direction of dialog, check position of vertical bar again. The vertical scroll bar stays at the right side. <-- Problem
Created attachment 21874 [details] [review] Proposed patch - based on CVS 2003/Nov/19
The proposed patch is the same one at the above-mentioned URL. Thanks.
I've committed my patches now.