GNOME Bugzilla – Bug 107211
GOK can't match more than 2 modifiers
Last modified: 2004-12-22 21:47:04 UTC
something seems to be broken in GOK's parsing code for modifiers; though more than one modifier can be matched using strtok: i.e. "shift+mod2" or "shift+capslock", when three modifiers are strung together the algorithms fails, i.e "shift+capslock+mod2" doesn't match. Of course long-term this whole approach probably needs rethinking since we don't really want to do this much string comparison and tokenizing just to figure out what labels to match... but in the short term it'd be nice to fix this since it _is_ breaking GOK's ability properly display keypad keys for Shift+CapsLock+NumLock.
Created attachment 14913 [details] [review] patch to gok-key.c,checks label sizes whenever labels are updated.
oops. please ignore the above patch, it belongs to another bug!
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME bug list :)
adding dependency on 108137; we should fix the modifier code in generally as part of the (much needed!) modifier-code refactor.
reducing severity for now, but this bug will block effective use with some international keyboards.
internationalization implications since many non-En keyboards use multiple modifiers to produce a wider character set.
A fix for this is in the gok_i18n branch. We can close this bug when we merge.
merge completed. Need to file RFE regarding keyboard 'groups' however, since they don't turn up in the standard X modifier bits. We need to be able to detect the current 'group' state in order to deal with really complex XKB keymaps.