After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106271 - using mv in makefile
using mv in makefile
Status: RESOLVED FIXED
Product: gnome-themes
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Calum Benson
Calum Benson
Depends on:
Blocks:
 
 
Reported: 2003-02-17 01:32 UTC by Sean Middleditch
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Description Sean Middleditch 2003-02-17 01:32:32 UTC 
In the LowContrastLargePrint/Makefile.am, a command 'mv foo /some/path' is
there - this should probably use 'install', and even if not, that must be
$(DESTDIR)/some/path - I have to patch it to build packages of the file,
since the package system in Arch Linux needs 'make DESTDIR=/blah install'
to work.
Comment 1 Kjartan Maraas 2003-05-03 07:19:22 UTC 
Looks like it's just moving away the theme under a certain condition (CORE_THEMES_ONLY). Something that's there for testing?
Comment 2 Calum Benson 2003-05-06 16:04:55 UTC 
It's there for more than testing (it happens in the default build), it
is indeed a bit of an ugly hack.  Needs fixing once I understand what
the right fix should be ...
Comment 3 Sean Middleditch 2003-05-06 16:07:53 UTC 
just adding $(DESTDIR) in front of the path fixes at least the issues
I have.  The thing is, DESTDIR is a "standard" prefix - if you don't
put that in front of any custom path operations, then usage of it will
fail; that's my only gripe.
Comment 4 Calum Benson 2003-05-07 12:37:15 UTC 
*** Bug 48403 has been marked as a duplicate of this bug. ***
Comment 5 Calum Benson 2003-05-07 12:39:29 UTC 
D'oh bollocks, typed in the wrong field... this is NOT a duplicate of
48403.
Comment 6 Calum Benson 2003-05-07 12:41:19 UTC 
As far as I can see, all the 'mv's are already in the format
($DESTDIR)/from ($DESTDIR)/to ... can you try the latest tarball
(2.3.2) or build from HEAD, and see if you still have the problem?
Comment 7 Sean Middleditch 2003-05-07 13:26:23 UTC 
Unfortunately, not really - I don't package for the distro where I ran
into this bug, or even use that distro anymore.

Something simple like
 ./configure --prefix=/test && make DESTDIR=$HOME/blah install
should reproduce if there's still a problem - all the files should end
up in $HOME/blah/test

If this package doesn't need GNOME 2.3, I can try building it myself
if you need, when I get home tonight.
Comment 8 Calum Benson 2003-05-09 17:46:07 UTC 
Just tried and it seems to work for me, but confirmation would be
useful, thanks...
Comment 9 Sean Middleditch 2003-05-09 19:36:03 UTC 
Had trouble getting 2.3.2 to build (building engines, the paths to .so
files are used versus -lname, and that doesn't seem to work on this
RedHat9 box... need to figure out if that's a redhat issue or no - may
be Nyquist's RPM's).

After a bit of symbolic linking, I got it to build - quick test case
is, as a normal (non root) user,

./configure --prefix=/non/existant/directory && make && make
DESTIR=`pwd`/installdir install

All the files went into `pwd`/installdir/non/existant/directory as
expected.  So, bug seems fixed, in gnome-themes 2.3.2.  ^,^
Comment 10 Calum Benson 2003-05-12 11:37:06 UTC 
Great, thanks.  Closing as FIXED then.