After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104621 - AtkHypertext needs link-selected signals
AtkHypertext needs link-selected signals
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: padraig.obriain
padraig.obriain
Depends on:
Blocks: 95923 104622
 
 
Reported: 2003-01-28 14:29 UTC by bill.haneman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (6.69 KB, patch)
2003-01-29 09:26 UTC, padraig.obriain
none Details | Review

Description bill.haneman 2003-01-28 14:29:10 UTC
AtkHypertext needs to emit signals indicating which link in a hypertext
object is currently selected (or "focussed").  Focus technically stays on
the   AtkHypertext object, but clients need to know which link is currently
selected both to track the user's onscreen logical position in a hypertext
object, but also to know which link is currently selected and thus would be
activated by various keybindings.

There may also need to be a queryable property for selected-link, or a
similar means of determining if a Hyperlink object is currently selected.
Comment 1 padraig.obriain 2003-01-29 09:26:41 UTC
Created attachment 13906 [details] [review]
Proposed patch
Comment 2 bill.haneman 2003-01-29 10:23:18 UTC
Patch looks good Padraig, thanks!

How should we handle the case where a new Hypertext object is created
with a 'selected' link?  Do we assume there's no link selected
initially , and emit the signal on AtkHyperlink creation if, in fact,
a link is initially selected?
Comment 3 padraig.obriain 2003-01-29 11:39:24 UTC
The interface does not mandate what should happen.

My initial thoughts are that a signal would not be emitted. We do not
emit a signal to indcate that an AtkObject has focus or is selected
when it is created.
Comment 4 bill.haneman 2003-01-29 11:54:51 UTC
sounds reasonable... the case I had in mind was one where a big
AtkHypertext object gets created with lots of links, one of which is
selected initially.  Without the generation of a signal in this case,
would a listening client would have to call
atk_hyperlink_is_selected() or whatever on every child in order to
determine that state?  Or would it just get the 'selected-link'
property ?  (I guess the latter, via standard GObject API).
Comment 5 padraig.obriain 2003-01-29 12:05:31 UTC
atk_hypelink_is_selected_link() is just a convenience function for the
property selected-link.

Do you think that we need a function
atk_hypertext_get_selected_link()?
Comment 6 padraig.obriain 2003-01-30 17:06:18 UTC
Patch committed to CVS HEAD.
Comment 7 Elijah Newren 2004-07-09 17:34:00 UTC
*** Bug 147116 has been marked as a duplicate of this bug. ***