After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 103812 - Right-click for suit feature broken in aisleriot
Right-click for suit feature broken in aisleriot
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.1.x
Other Linux
: High minor
: ---
Assigned To: Rosanna Yuen
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-18 14:06 UTC by Noèl Köthe
Modified: 2012-01-31 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Noèl Köthe 2003-01-18 14:06:23 UTC
Hello,

a bug report from a Debian user:

http://bugs.debian.org/174812

"The Gnome 1 version of aisleriot had a feature (sometimes partially
broken though; for instance I couldn't get it to work in freecell)
where you could right-click on a partially visible card to make it
fully visible (useful, for instance, to see its suit). In the upgrade
to Gnome 2, this feature appears to have been completely broken.

The appended patch seems to fix it. I haven't submitted it upstream,
since I wasn't clear on the best way to do so. (I couldn't tell if
there was a mailing list or anything other than their bugzilla).

Index: events.c
===================================================================
RCS file: /cvs/gnome/gnome-games/aisleriot/events.c,v
retrieving revision 1.37
diff -u -r1.37 events.c
--- events.c	30 Sep 2002 12:37:13 -0000	1.37
+++ events.c	31 Dec 2002 04:07:49 -0000
@@ -115,10 +115,6 @@
   static guint dbl_click_time = 250;
   static int first_press;
 
-  /* We only want first mouse click*/
-  if (event->button != 1)
-
  return TRUE;
-  
   /* ignore the gdk synthetic click events */
   if (event->type != GDK_BUTTON_PRESS && event->type != GDK_2BUTTON_PRESS)
     return TRUE;
@@ -135,7 +131,9 @@
   press_data->yoffset = event->y;
   press_data->hslot = hslot;
   press_data->cardid = cardid;
-  if (!(press_data->status == STATUS_CLICK && event->button ==
GDK_2BUTTON_PRESS)) {
+  if (event->button == 1 &&
+      !(press_data->status == STATUS_CLICK
+
&& event->type == GDK_2BUTTON_PRESS)) {
     first_press = get_current_time();
     press_data->status = cardid > 0 ? STATUS_MAYBE_DRAG : STATUS_NOT_DRAG;
   }
@@ -178,7 +176,6 @@
 
 gint button_release_event (GtkWidget *widget, GdkEventButton *event, void *d)
 {
-  if (event->button != 1) return TRUE;
   switch (press_data->status) {
   case STATUS_IS_DRAG:
     press_data->status = STATUS_NONE;

"

Thank you.
Comment 1 Elijah Newren 2003-01-18 16:43:17 UTC
Adding the PATCH keyword, and to make it visible, I'm going to mark
priority high and mark this as new.
Comment 2 Alex Duggan 2003-03-21 02:23:58 UTC

*** This bug has been marked as a duplicate of 83210 ***
Comment 3 Alex Duggan 2003-03-21 02:24:43 UTC
sorry about that :)
Comment 4 Callum McKenzie 2003-06-13 06:23:52 UTC
How did I miss closing this ? The problem has been fixed in CVS for a
week.
Comment 5 Robert Ancell 2012-01-31 23:23:58 UTC
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!