GNOME Bugzilla – Bug 101760
Remove unnecessary markup from glade messages in gnome-utils
Last modified: 2005-01-24 15:55:20 UTC
#: gfloppy/src/gfloppy2.glade.h:4 msgid "<span weight=\"bold\">Filesystem settings</span>" #: gfloppy/src/gfloppy2.glade.h:5 msgid "<span weight=\"bold\">Formatting mode</span>" #: gfloppy/src/gfloppy2.glade.h:6 msgid "<span weight=\"bold\">Physical settings</span>" This use of markup inside messages marked for translation is totally unnecessary, and a problem for the translation process. For details, see the problem description in bug 96836. Since these are glade messages, I'll mark it dependant on the glade bug 97061 in the mean time.
I'm not going to have time to fix this before the 31st dec [string freeze] - anyone who has time, please commit patches to HEAD.
missed the deadline on this one.
What should be done about this b.t.w.? Is the correct thing just to remove the markup? or .. ?
The correct thing to do is to fix Glade (see bug 97061). However, from a translation standpoint, simply removing the markup is fine too, but then you may not be following the HIG any longer if it says that these messages should be bold.
Created attachment 36048 [details] [review] Proposed patch This patch removes the markup from the glade file and adds it when we are setting up widgets in main.c It has one change which may have unintended consequences. I didn't see any myself, but I am not familiar with the code. I had to move the init_devices() call to lower in the function, after all the widget setup code. Otherwise, if you don't have a device, you'll see a greyed out main window without bolded headers. I think this move is good even without the rest of the patch though, as the code sets the widgets up in other ways besides bolding, and if we are presenting the window to the user at all, we shouldn't show them a half-finished window.
James, what do you think of the patch ?
Michael, I committed your patch in order to get it into 2.9.90. Thanks !