Created attachment 13079 [details] [review]
build patch

Building file roller works for me, I don't use jhbuild and don't know
why it does not work. 

You should try to download file roller by hand and see if it compiles.

What automake version are you using? I'm using 1.7.2 (that's installed
by jhbuild).

automake 1.6.3

It's probably automake 1.7.2 that has more strict rules then. What
happens when you remove the line in src/Makefile.am with automake
1.6.3? Will it still build? If so, you could probably remove it
safely. If that's ok with the release team etc.

<paolo> Is someone of you able to build file-roller from current CVS HEAD?
<paolo> I get:
<paolo> src/Makefile.am:104: @LIBOBJS@ seen but never set in
`configure.in'
<paolo>  
<paolo> **Error**: `automake' failed. Please fix the warnings
<paolo> (probably missing development files) and try again.
<chema> paolo: looks like you didn't autogened
<paolo> chema: I get it running autogen
<xan> paolo: same here
<xan> paolo: since yesterday or so<danielk> paolo: I think @LIBOBJS@
is deprecated.  Others and me get that too with file-roller.
<danielk> s/deprecated/was deprecated and has been killed/
<paolo> danielk:: any idea on how to fix it?
<jeroen> paolo: removing it?
<danielk> paolo: Depends on what it's used for -- I haven't looked
yet.  For generic info see the automake or autoconf manual, I think it
elaborates specifically on the LIBOBJS issue.


Removing @LIBOBJS@ seems to work for me.

with automake 1.7.2 and autoconf 2.57 it only gives a warning that
acconfig.h is obsolete but bilding works good, please test.

*** Bug 104990 has been marked as a duplicate of this bug. ***

Here is a possible solution I posted on another bug report:

  Removing @LIBOBJS@ from the makefile is wrong, and will break the
  build on other systems.

  The problem is that older automakes aren't picking up that newer
  autoconf's are actually defining LIBOJBS.  The correct fix to get it
  working with older automakes is to add the following line to
  configure.in:
     AC_SUBST(LIBOBJS)

  Strictly speaking this is redundant, but it is not harmful (and will
  stop old automakes complaining).

If anyone is still having issues, try making the above change to the
configure.in and add comments on your successes or failures.

Created attachment 14085 [details] [review]
Fix for automake issues!

I have tracked the issues down and yes James is right so far. But the
problem is differently.

Assumption:

To build todays GNOME we require automake 1.4-p6, automake 1.6 and
automake 1.7.

The gnome-common package ships a default autogen.sh file which first
searches for automake-1.4 regardless if you have a newer version of
automake installed or not. A lot of GNOME modules that require a newer
version of automake don't use the default gnome-common autogen.sh file
and provide their individual one. Here an attachment of a fixed
autogen.sh that makes sure to use the correct version of automake 1.7

Alternative solution, someone needs to adjust gnome-common autogen.sh
and make the 1.4 version inside optional and export it outside so
every individual module has to provide it's own version number

e.g. autogen.sh for gnome-common is set without automake version and
the individual module such as fileroller exports VERSION=1.7 in the
autogen.sh so nothing can go wrong.

Greets.

gnome-common will die (probably, and probably slowly), so gnome-common
should not be part of the solution. A versioned autogen.sh might be
fine. My autogen.sh in gnome-hello is meant to be a fairly canonical
example.

*** Bug 105193 has been marked as a duplicate of this bug. ***

I also experienced this same bug.  Ali Akcaagac's patch allowed me
pass this stage, though I ran into other build problems (which I've
reported in bug 115311).  Can Ali's patch be committed?  I'm adding
myself to the cc...

2003-06-17  Paolo Bacchilega  <paolo.bacch@tin.it>

	* src/Makefile.am (file_roller_LDADD): removed LIBOBJS, no more
	needed because fnmatch is gone now.