GNOME Bugzilla – Bug 100815
[ui-review] Context menus from document tabs should be accessible with shift+f10
Last modified: 2005-01-12 17:13:03 UTC
From the ui-review: Main view - <Eimi> Did anyone mention all the bevels around the status bar parts of the main window? Might be a bit less visually cluttered flatter. - Context menus from document tabs should be accessible with shift+f10 - s/Move to a new window/Move to New Window - Inactive tabs aren't drawn with the proper theme colours
s/Move to a new window/Move to New Window -> DONE
- Inactive tabs aren't drawn with the proper theme colours -> Should be fixed with current gtk+
Still to be done: - Context menus from document tabs should be accessible with shift+f10
Paolo, the context menu works for me in the latest version. Shall we close this if so?
Maybe I'm understanding things wrong, but I think that the bug is about the context menu of the _tab_ (the one containing "Move to New Window" etc). To me it looks like it's not fixed yet: shift+f10 when the file name in the tab label is focused doesn't pop up any menu.
Nope, I think I misunderstood this bug, thanks for clearing that up. If I have time, I might be able to send in the patch for this, but probably not until after the holidays.
Is there any point in having this context menu at all? All the entries on it can be accessed from the main menu and having a context menu on the tab headers seems a bit unconventional, and also difficult to discover. Also, Epiphany uses "Detach Tab" instead of "Move to New Window" - not sure which is better, but they should be the same.
I prefer "Move to New Window". I'd like to have this bug fixed. Is anyone willing to provide a patch?
I took a quick look (really quick! maybe I'm totally wrong :) but this doesn't seems so trivial to solve as it seems: the widget that is packed into the notebook label is constructed in gedit_mdi_child.c where also the popup menu is constructed. This widget receives the button-press-event signal so right clicking workd fine. On the other hand it looks like this widget does *not* receive the popup-menu signal that would make shift+f10 work. I dunno where that signal gets trapped... maybe in the notebook widget itself, but I'm just guessing.
Created attachment 35433 [details] [review] proof of concept This pops up the context menu on Shift-F10 when the tab label is focused. I think it's in the wrong place though, it should belong in gedit-mdi.c not bonobo-mdi.c, but I could find no way to get the newly-created notebook (book_create, book_add_view) from gedit-mdi... any hints?
Thanks for giving this a try... Yes, afaik there is no way to obtain the Notebook widget from gedit-mdi and on the other hand bonobo-mdi was supposed to be a generic widget without dependecies on gedit. Anyway this is a bit of moot point: at some point we need to replace this whole bonobo-mdi stuff with a new MDI widget which uses UIManager instead of bonobo etc
Christian: thank you very much for taking the time to look at this bug and providing a patch. Since all the commands present in the context menu are easily accessible using the main menu and since it seems not possible to close this bug in a sane way (the Chris' patch works but as he said is only a proof of concept) I'm thinking to close it as a WONTFIX. Please, reopen this bug only if you have a sane patch or if you can prove this is a serious accessibility problem. We will fix it in a definitive way when we will replace the bonobo-mdi stuff with a new MDI widget based on UIManager.