GNOME Bugzilla – Bug 96633
support RTL flipping in stock icons
Last modified: 2011-02-04 16:16:03 UTC
all stock icons for which the direction is important should be verified and if needed mirrored depending on the direction
Moving all the RTL flipping bugs to the 2.4.0 milestone; in some cases the changes should be easy to do. (GtkPaned comes to mind) In those cases, we can move the bugs back to 2.2.0 if patches occur.
Owen already fixed forward and back (see bug 92211), but I think all icons involving horizontal arrows need similar treatment. These are: certainly: GTK_STOCK_GOTO_FIRST GTK_STOCK_GOTO_LAST probably: GTK_STOCK_JUMP_TO GTK_STOCK_QUIT maybe: GTK_STOCK_REDO GTK_STOCK_REVERT_TO_SAVED GTK_STOCK_UNDELETE GTK_STOCK_UNDO probably not: GTK_STOCK_OK GTK_STOCK_REFRESH Go to http://developer.gnome.org/doc/API/2.0/gtk/gtk-stock-items.html for a quick overview of the stock icons. I probably need help from artists and native RTL speakers for progress on this (beyond fixing goto_first/goto_last).
I am a Hebrew speaker, and a developer specialised in i18n matters. My advice is that the following stock icons must be swapped, but only when the whole geometry of the window is made RTL (I omit the GTK_STOCK prefix common to all items): GOTO_FIRST <==> GOTO_LAST GO_BACK <==> GO_FORWARD JUMP_TO REVERT_TO_SAVED UNDO and REDO are debatable. They are not symmetrized in the Hebrew- localized GUI for MS Word, so it is probably best to leave them as-is. I have a vaguely related suggestion: it seems that gtk supports JUSTIFY_LEFT and JUSTIFY_RIGHT. I suggest to add JUSTIFY_START and JUSTIFY_END. JUSTIFY_START is equivalent to JUSTIFY_LEFT in a LTR geometry, and to JUSTIFY_RIGHT in a RTL geometry. JUSTIFY_END is the opposite. Matitiahu Allouche
But REVERT_TO_SAVED, UNDELETE and UNDO all share the same arrow to indicate a "undo"-kind of operation. So if we flip one of them, we surely have to flip all for consistency ? And then we also have to flip REDO, since the main feature of REDO is that its arrow is in the opposite direction to UNDO... You don't think that QUIT should be flipped ?
Created attachment 11944 [details] [review] patch flipping GOTO_FIRST, GOTO_LAST and JUMP_TO
Created attachment 11945 [details] stock_jump_to_rtl_16.png
Created attachment 11946 [details] stock_jump_to_rtl_24.png
I'm going to attach a patch which additionally flips UNDO and REDO; it should probably not be applied without also flipping UNDELETE and REVERT_TO_SAVED (for consistency reasons as explained above). However, properly flipping UNDELETE and REVERT_TO_SAVED is probably impossible without the .xcf sources, which I don't have... Maybe some of the famous gnome artists can come to my rescue here...
Created attachment 11947 [details] [review] patch which additionally flips UNDO and REDO
Created attachment 11948 [details] stock_undo_rtl_16.png
Created attachment 11949 [details] stock_undo_rtl_24.png
Created attachment 11950 [details] stock_redo_rtl_16.png
Created attachment 11951 [details] stock_redo_rtl_24.png
First patch (FIRST, LAST, JUMP_TO) committed now.
Any chance to get hold of .xcfs for UNDELETE and REVERT_TO_SAVED, or for versions with flipped arrows ?
Removing PATCH, as all attached patches have been committed. Still waiting for a word from the artists...
Created attachment 17261 [details] libgnomeui-stock.tar
Oops, why did I attach _that_? Too late I guess ;) Proper set follows
Created attachment 17263 [details] stock-part.tar
Wouldn it make sense to actually distribute the .xcf's with gtk+? It seems reasonable to ship with the "source" to the stock icons.
Thanks Jakub. I have delivered all needed rtl variants to HEAD now.