Creating a patch to create a help button on the dialog box 
and link the button to the appropieate section in the help
document.

Created attachment 8850 [details] [review]
Proposed patch

I assume from this patch that there is a section in the docs to point
to here? Reassigning to nautilus-maint - I should not review code pathes.

Damon: could you shepherd this patch?

I'm not sure that help page is really appropriate here.
It links to '1.8.2. Changing Backgrounds', which only describes the
patterns and colors, not the emblems. I think ideally there should
be a help section that just describes the dialog.

I think we need to ask the doc authors if the section was intended
to be linked from here. I'll mail the Sun docs team.


Also, a few minor comments on the patch itself:

  o I don't think the Help button should grab the default or focus
    as it isn't the default button.
  o It needs to be on the left edge of the dialog, like normal Help
    buttons. Currently it is displayed right next to the other buttons
    with no space between them. Also if you switch to the 'Emblems'
    page one of the other buttons is drawn partly over it.

Thanks for the comment. I applied the patch on the latest 
source, but I see

-The help button on the left hand side only and "Add a new pattern"
 and "close" button on the right hand side.
-Clicking on emblems does not affect the help button
-It's the "close" button that has the default focus.

Could you tell me how do you get the above results, so that I can 
simulate it.

I've cc'ed Eugene. Eugene - did you intend the Help button on the
'Edit/Background and Emblems' dialog to link to the '1.8.2. Changing
Backgrounds' section?


About the button problem - it only becomes a problem after you'd added
patterns and emblems. Then you also get the 'Remove an Emblem/Pattern'
button, so there isn't much space left for the 'Help' button.
So if you add an emblem you should see it.


The focus thing isn't a problem, it is just unnecessary code:

+
gtk_widget_grab_default (temp_button);
+
gtk_widget_grab_focus (temp_button);

There isn't needed.

Yes I did intend the Help button to link to the Changing Backgrounds 
information. I know that the information in this section does not 
cover all of the functionality of this dialog. 

Our approach in the User Guide is to document _tasks_ rather than 
dialogs. I think it makes most sense to make two dialogs: a 
Backgrounds dialog and an Emblems dialog. From a user point of view, 
there is no reason for them to be together. Putting these two 
disparate functions together is ultimately what causes the Help 
button to link to information for only one of the sections.

Cc'ing Calum for usability point-of-view.

bug 84507 proposes separating this dialog into two. Actually as I
mention in that bug, i think we should just ditch thebackgrounds
feature...but i'll leave that discussion to bug 84507.

Certainly agree it's a bit of a hotch-potch in this area-- as well as
emblems bearing no relation to emblems, why should you be able to
change background colours via an item on the View menu at all, when
you have to go into Preferences to change the theme?  :/

s/no relation to emblems/no relation to background colo[u]rs :)

OK. I don't really mind if that's what was intended.
(I suppose we could make it show section '1.6.1. To Add an Emblem to a
File or Folder' if you are on the emblems page, if you think that is
better.)

I'll have a look at fixing the Help button.

Created attachment 9143 [details] [review]
Revised patch that fixes the issues with the Help button placement

+
gtk_widget_show(temp_button);
and
+
gtk_box_pack_start (GTK_BOX(property_browser->details->bottom_box),
temp_button, FALSE, FALSE, GNOME_PAD_SMALL);
Is lacking spaces before paranthesis.

The dialog in the help callback should be declared at the top of the
function.

Otherwise it looks fine. Please commit.

patch applied.

Verified the fix on Sept 17th 2002 build checked out form CVS.So the 
bug can be closed.