After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 80731 - Desktop icon view not being destroyed.
Desktop icon view not being destroyed.
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Desktop
0.x.x [obsolete]
Other other
: High normal
: 1.1.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 73787
 
 
Reported: 2002-05-03 19:57 UTC by Dave Camp
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove the ref and unref in the mount parameters (1.33 KB, patch)
2002-05-03 20:00 UTC, Dave Camp 		none Details | Review

Description Dave Camp 2002-05-03 19:57:15 UTC 
When you turn off nautilus drawing the desktop, the desktop icon view is
not destroyed.

The MountParameters (user data for the UI listeners on the desktop icon
view component) are holding references to the icon view.  They only release
these references when the ui component is finalized.  The ui component is
only finalized when the icon view is destroyed.

The attached patch just removes the ref and unref pair.  Given that the
MountParameters are always destroyed when the icon view is destroyed makes
the refs somewhat useless.
Comment 1 Dave Camp 2002-05-03 20:00:12 UTC 
Created attachment 8166 [details] [review]
remove the ref and unref in the mount parameters
Comment 2 Dave Camp 2002-05-03 20:18:48 UTC 
After applying this I got crashes that were caused by bug 80733 when
switching the desktop setting on and off.
Comment 3 Heath Harrelson 2002-05-06 09:13:14 UTC 
Patch -> high.
Comment 4 Darin Adler 2002-05-09 19:13:57 UTC 
In the past, there have been some subtle lifetime issues with 
these objects. I worry that just removing the ref/unref alone could 
introduce some problems. If it did, adding a weak pointer might 
help.

On the other hand, I don't have a good idea of how to reproduce 
such problems.

So I guess it's OK to check in this change. Feel free to commit.
Comment 5 Dave Camp 2002-05-09 20:35:01 UTC 
Committed.