GNOME Bugzilla – Bug 797293
splitmuxsink: Do not hardcode frames_of_daily_jam
Last modified: 2018-10-16 13:08:23 UTC
See commit message
Created attachment 373942 [details] [review] splitmuxsink: Do not hardcode frames_of_daily_jam Apart from the obvious drawbacks of hardcoding, the drawback here was that, if we subtracted 2 frames (instead of 2.6) from the target running time, we'd request the next keyframe a bit too far into the future, which would make our files split at the wrong position.
Review of attachment 373942 [details] [review]: Makes sense
Review of attachment 373942 [details] [review]: commit af0e30d5452d87117dd6371fd15e213af5524ac4 (HEAD -> master, origin/master, origin/HEAD) Author: Vivia Nikolaidou <vivia@ahiru.eu> Date: Tue Oct 16 15:42:12 2018 +0300 splitmuxsink: Do not hardcode frames_of_daily_jam Apart from the obvious drawbacks of hardcoding, the drawback here was that, if we subtracted 2 frames (instead of 2.6) from the target running time, we'd request the next keyframe a bit too far into the future, which would make our files split at the wrong position. https://bugzilla.gnome.org/show_bug.cgi?id=797293