After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795707 - msdk: enc: Add Dmabuf Export support
msdk: enc: Add Dmabuf Export support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 789886
 
 
Reported: 2018-05-01 01:00 UTC by sreerenj
Modified: 2018-05-02 21:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add dmabuf-export support using CapsFeatures (6.92 KB, patch)
2018-05-01 21:48 UTC, sreerenj 		none Details | Review
msdk: enc: enable dmabuf-export (7.08 KB, patch)
2018-05-02 21:48 UTC, sreerenj 		committed Details | Review

Description sreerenj 2018-05-01 01:00:33 UTC 
Add dmabuf-export support in msdk encoder similar to the msdkvpp.
Currently, we only can support dmabuf-export through DMABufCapsfeatures.

Support for dmabuf-import should be handled here: https://bugzilla.gnome.org/show_bug.cgi?id=794817
Comment 1 sreerenj 2018-05-01 21:48:12 UTC 
Created attachment 371588 [details] [review]
Add dmabuf-export support using CapsFeatures
Comment 2 sreerenj 2018-05-02 21:48:33 UTC 
Created attachment 371631 [details] [review]
msdk: enc: enable dmabuf-export

The first patch had a code block to create a new pool for copying the incoming buffers if a) dmabuf-capsfeature negotiated and b) upstream rejected the msdk proposed pool. This won't work since the dmabuf backed msdk buffers are not mappable. One possible solution could be to keep the internal pool based on video memory (not-dmabuf) and propose a dmabuf-backed pool in propose_allocation.  For now, it just errors out if the above scenario occurs.
Comment 3 sreerenj 2018-05-02 21:55:50 UTC 
Review of attachment 371631 [details] [review]:

pushed as cb1eb650c6826e49ca99965824dd079842c61400