GNOME Bugzilla – Bug 795275
Many mimetypes are missing from TheGamesDB plugin
Last modified: 2018-04-24 13:15:57 UTC
The following MIME types that gnome-games supports are missing from the plugin: * application/x-atari-lynx-rom * application/x-fds-disk * application/x-wonderswan-rom * application/x-wonderswan-color-rom Additionally, TheGamesDB has separate platforms for Neo-Geo Pocket and Neo-Geo Pocket Color, and also PC Engine/TurboGrafx-16 and PC Engine/TurboGrafx-CD. Neo-Geo Pocket Color support depends on https://bugzilla.freedesktop.org/show_bug.cgi?id=106055 Since TurboGrafx-CD games are just generic CD images, there isn't a registered MIME type for them, similar to PlayStation: https://bugzilla.gnome.org/show_bug.cgi?id=769347
Created attachment 370956 [details] [review] thegamesdb: Add Atari Lynx support Add Atari Lynx support via the 'application/x-atari-lynx-rom' MIME type.
Created attachment 370957 [details] [review] thegamesdb: Add Famicom Disk System support Add FDS support via the 'application/x-fds-disk' MIME type.
Created attachment 370958 [details] [review] thegamesdb: Add WonderSwan support Add WonderSwan support via the 'application/x-wonderswan-rom' MIME type.
Created attachment 370959 [details] [review] thegamesdb: Add WonderSwan Color support Add WonderSwan Color support via the 'application/x-wonderswan-color-rom' MIME type.
Created attachment 370960 [details] [review] thegamesdb: Add Neo-Geo Pocket Color support Add NGPC support via the 'application/x-neo-geo-pocket-color-rom' MIME type.
Created attachment 370961 [details] [review] thegamesdb: Add TurboGrafx-CD support Add TurboGrafx-CD support via the unregistered 'application/x-pc-engine-cd-rom' MIME type as none is registered for TurboGrafx-CD discs.
See also: https://bugzilla.gnome.org/show_bug.cgi?id=770390 https://bugzilla.gnome.org/show_bug.cgi?id=770391
Review of attachment 370956 [details] [review]: Looks good.
Review of attachment 370957 [details] [review]: Sure.
Review of attachment 370958 [details] [review]: You can merge this with the WonderSwan color support.
Review of attachment 370959 [details] [review]: Merge this into the WonderSwan commit.
Review of attachment 370960 [details] [review]: This mime-type doesn't exist upstream. Please add a reference to https://bugs.freedesktop.org/show_bug.cgi?id=106055 in the commit message > Add NGPC You can write it in full...
Review of attachment 370961 [details] [review]: ::: src/lua-factory/sources/grl-thegamesdb.lua @@ +226,3 @@ platform_names['application/x-pc-engine-rom'] = 'TurboGrafx 16' + -- 'application/x-pc-engine-cd-rom' is an unregistered MIME type + platform_names['application/x-pc-engine-cd-rom'] = 'TurboGrafx CD' At this point, we might want to move all those "unregistered mime-types" to a separate section, so that optical disc formats that can't be detected through magic are all together.
Can you also add support for the Sega CD? :)
Created attachment 371035 [details] [review] thegamesdb: Add WonderSwan and WonderSwan Color support Add WonderSwan and WonderSwan Color support via 'application/x-wonderswan-rom' and `application/x-wonderswan-color-rom' MIME types.
Created attachment 371036 [details] [review] thegamesdb: Add Neo-Geo Pocket Color support Add Neo-Geo Pocket Color support via the 'application/x-neo-geo-pocket-color-rom' MIME type: https://bugs.freedesktop.org/show_bug.cgi?id=106055
Created attachment 371037 [details] [review] thegamesdb: Add TurboGrafx-CD support Add TurboGrafx-CD support via the unregistered 'application/x-pc-engine-cd-rom' MIME type as none is registered for TurboGrafx-CD discs, similar to PlayStation games. Also move both TurboGrafx-CD and PlayStation to a separate section.
(In reply to Bastien Nocera from comment #14) > Can you also add support for the Sega CD? :) Sega CD is already there. It is detected via libmagic.
(In reply to Bastien Nocera from comment #12) > Review of attachment 370960 [details] [review] [review]: > > This mime-type doesn't exist upstream. Please add a reference to > https://bugs.freedesktop.org/show_bug.cgi?id=106055 in the commit message > I'm not sure about the wording here, so I've just appended a link for now. :/
Review of attachment 371035 [details] [review]: Looks good.
Review of attachment 371036 [details] [review]: Yes.
Created attachment 371054 [details] [review] thegamesdb: Add TurboGrafx-CD support Add TurboGrafx-CD support via the unregistered 'application/x-pc-engine-cd-rom' MIME type as none is registered for TurboGrafx-CD discs, similar to PlayStation games. Also move both TurboGrafx-CD and PlayStation to a separate section.
Review of attachment 371037 [details] [review]: ::: src/lua-factory/sources/grl-thegamesdb.lua @@ +225,3 @@ platform_names['application/x-nintendo-ds-rom'] = 'Nintendo DS' platform_names['application/x-pc-engine-rom'] = 'TurboGrafx 16' + -- 'application/x-pc-engine-cd-rom' is an unregistered MIME type No, I would have wanted the unregistered "optical disc images" formats to be move below this, and add a linefeed, something like: --- a/src/lua-factory/sources/grl-thegamesdb.lua +++ b/src/lua-factory/sources/grl-thegamesdb.lua @@ -217,8 +217,6 @@ function get_platform_name(mime_type, suffix) platform_names['application/x-nes-rom'] = 'Nintendo Entertainment System (NES)' platform_names['application/x-nintendo-ds-rom'] = 'Nintendo DS' platform_names['application/x-pc-engine-rom'] = 'TurboGrafx 16' - -- 'application/x-playstation-rom' is an unregistered MIME type - platform_names['application/x-playstation-rom'] = 'Sony Playstation' platform_names['application/x-saturn-rom'] = 'Sega Saturn' platform_names['application/x-sega-cd-rom'] = 'Sega CD' -- Also represents 'Sega Game Gear' through magic @@ -227,6 +225,10 @@ function get_platform_name(mime_type, suffix) platform_names['application/x-wii-rom'] = 'Nintendo Wii' platform_names['application/x-wii-wad'] = 'Nintendo Wii' + -- unregistered MIME types for optical disc formats + platform_names['application/x-playstation-rom'] = 'Sony Playstation' + platform_names['application/x-pc-engine-cd-rom'] = 'TurboGrafx CD' + -- For disambiguation if suffix and suffix ~= 'bin' and
Review of attachment 371054 [details] [review]: That's the one ;)
commit 6e8a504228178f8e094857f9542771f6bb40efb9 Author: Exalm <exalm7659@gmail.com> Date: Sun Apr 15 19:22:10 2018 +0500 thegamesdb: Add TurboGrafx-CD support Add TurboGrafx-CD support via the unregistered 'application/x-pc-engine-cd-rom' MIME type as none is registered for TurboGrafx-CD discs, similar to PlayStation games. Also move both TurboGrafx-CD and PlayStation to a separate section. https://bugzilla.gnome.org/show_bug.cgi?id=795275 commit 132f6c4af8ac945795520f239d7290c8fd899caa Author: Exalm <exalm7659@gmail.com> Date: Sun Apr 15 19:20:19 2018 +0500 thegamesdb: Add Neo-Geo Pocket Color support Add Neo-Geo Pocket Color support via the 'application/x-neo-geo-pocket-color-rom' MIME type: https://bugs.freedesktop.org/show_bug.cgi?id=106055 https://bugzilla.gnome.org/show_bug.cgi?id=795275 commit f8b9bad19d522c2f8cd25bb3e56a02f348d26fa3 Author: Exalm <exalm7659@gmail.com> Date: Sun Apr 15 19:18:17 2018 +0500 thegamesdb: Add WonderSwan and WonderSwan Color support Add WonderSwan and WonderSwan Color support via 'application/x-wonderswan-rom' and `application/x-wonderswan-color-rom' MIME types. https://bugzilla.gnome.org/show_bug.cgi?id=795275 commit c066a6a8451e610ab0f42701f8adba4fc9d84729 Author: Exalm <exalm7659@gmail.com> Date: Sun Apr 15 19:13:18 2018 +0500 thegamesdb: Add Famicom Disk System support Add FDS support via the 'application/x-fds-disk' MIME type. https://bugzilla.gnome.org/show_bug.cgi?id=795275 commit caeb5dc7b5b68e91afd4ae7146a01944e34c37be Author: Exalm <exalm7659@gmail.com> Date: Sun Apr 15 19:12:05 2018 +0500 thegamesdb: Add Atari Lynx support Add Atari Lynx support via the 'application/x-atari-lynx-rom' MIME type. https://bugzilla.gnome.org/show_bug.cgi?id=795275