GNOME Bugzilla – Bug 795224
wayland: don't poll if there are no pending frames
Last modified: 2018-04-20 05:07:14 UTC
With the patch from bug 795220, applications can have their own event queues in the same connection. Another thread that just loops over wl_display_dispatch_queue() on another queue will immediately stall the vaapisink.
Created attachment 370882 [details] [review] wayland: don't poll if there are no pending frames Otherwise the following poll may not return for an arbitrary amount of time. This can happen if another wayland event queue has flushed and read our events.
Review of attachment 370882 [details] [review]: Heh! this is also very similar with bug 772455 but yours adds the missing wl_display_cancel_read(), which I believe resolves what I said in https://bugzilla.gnome.org/show_bug.cgi?id=772455#c5 ... nice! nitpick: the indentation is not correct
Created attachment 371079 [details] [review] wayland: don't poll if there are no pending frames Indention fixed.
*** Bug 772455 has been marked as a duplicate of this bug. ***
Comment on attachment 371079 [details] [review] wayland: don't poll if there are no pending frames pushed as commit 1f71b5a5 attachment 371079 [details] [review] - wayland: don't poll if there are no pending frames
branch 1.14 * daa2f65e wayland: don't poll if there are no pending frames branch 1.12 * 1dc3c9e1 wayland: don't poll if there are no pending frames