GNOME Bugzilla – Bug 795043
Meson: Should generate a .pc file for each module
Last modified: 2018-04-25 20:10:08 UTC
Similar to bug #794568, we should generate .pc file for each static module because we cannot rely on .la for that when built with meson.
Created attachment 370618 [details] [review] Generate a .pc file for each module When static_modules is true, generate a .pc file to each module to be able to get their private dependencies. This uses a simplified pkg.generate() API added in Meson 0.46.0.
Note this cannot be merged yet because Meson 0.46 will be released only next week.
Review of attachment 370618 [details] [review]: Eh, OK... "accepted-commit_after_freeze" means whenever the new meson is available in gnome-build-meta.
Meson 0.46 has been released, is it ok to push now ?
(In reply to Xavier Claessens from comment #4) > Meson 0.46 has been released, is it ok to push now ? Not until the BuildStream freedesktop-sdk builds it: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/base/meson.bst (used by https://gitlab.gnome.org/GNOME/gnome-build-meta).
I'm from the old jhbuild school, how does it work to update meson there?
Update https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/base/meson.bst and send a merge request! If you don't have a gitlab.com account, you could also poke CodeThink about it in #release-team.
(In reply to Philip Withnall from comment #5) > Not until the BuildStream freedesktop-sdk builds it: > https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/ > base/meson.bst (used by https://gitlab.gnome.org/GNOME/gnome-build-meta). Almost forgot: you've just earned five release team brownie points! Yay!
(In reply to Michael Catanzaro from comment #7) > Update > https://gitlab.com/freedesktop-sdk/freedesktop-sdk/blob/master/sdk/elements/ > base/meson.bst and send a merge request! > > If you don't have a gitlab.com account, you could also poke CodeThink about > it in #release-team. Maybe better to poke CodeThink, because whoever prepares the MR really ought to have access to the CI.
Thanks, made the MR: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/merge_requests/209
Attachment 370618 [details] pushed as 62362f9 - Generate a .pc file for each module