GNOME Bugzilla – Bug 793647
Request periodic scans while WiFi list is open
Last modified: 2018-02-21 12:34:15 UTC
According to Bug 767918, NetworkManager wants to move the periodic scanning of networks to the clients. In doing so, we need to handle this in our side. The refresh button introduced in Bug 789869 was an attempt which doesn't quite fit to the UX we expect, and has been therefore reverted. See 793238
An interesting read on the subject https://blogs.gnome.org/dcbw/2016/05/16/networkmanager-and-wifi-scans/
Created attachment 368655 [details] [review] network: Request periodic Wi-Fi scans As NetworkManager from version 1.10 doesn't handle background scanning itself, to minimise battery drain, we need to periodically request it to scan for Wi-Fi Access Points. We now do this request every 15 seconds, as NetworkManager-applet and gnome-shell do.
Review of attachment 368655 [details] [review]: Looks good and works for me. Lgtm!
This way the rescan would continue even when the Wifi is off. Should we stop it?
Created attachment 368659 [details] [review] network: Request periodic Wi-Fi scans As NetworkManager from version 1.10 doesn't handle background scanning itself, to minimise battery drain, we need to periodically request it to scan for Wi-Fi Access Points. We now do this request every 15 seconds, as NetworkManager-applet and gnome-shell do, and disable that periodic scan if Wi-Fi is disabled.
(In reply to Felipe Borges from comment #4) > This way the rescan would continue even when the Wifi is off. > > Should we stop it? I've tried doing that in the attached patch. It should disable the periodic scanning when going into hotspot mode, or using the Wi-Fi toggle in the UI. It would be great if you could test by disabling the Wi-Fi toggle in gnome-shell as well.
Review of attachment 368659 [details] [review]: looks ok to me
(In reply to Bastien Nocera from comment #6) > It would be great if you could test by disabling the Wi-Fi toggle in > gnome-shell as well. Yes, it persists requesting scan even when the Wi-Fi is disabled in gnome-shell.
Created attachment 368672 [details] [review] network: Request periodic Wi-Fi scans As NetworkManager from version 1.10 doesn't handle background scanning itself, to minimise battery drain, we need to periodically request it to scan for Wi-Fi Access Points. We now do this request every 15 seconds, as NetworkManager-applet and gnome-shell do, and disable that periodic scan if Wi-Fi is disabled.
Created attachment 368673 [details] [review] wifi: Show the "Wi-Fi disabled" page if it is disabled Rather than an empty "Visible Networks" table.
Review of attachment 368672 [details] [review]: Nice. Now it stops polling properly.
Review of attachment 368673 [details] [review]: Sure. Later on, after this release, we should go with Bug 793254.
Hi guys, Instead of periodic wifi scan, is it possible to refresh network when : - Opening "Select Network" modal - Every n seconds when the "Wifi settings" window is open Please, it will do the great job without draining battery. Best,
(In reply to usbkey9 from comment #13) > Hi guys, > > Instead of periodic wifi scan, is it possible to refresh network when : > - Opening "Select Network" modal There's no "Select Network" modal in the Settings. > - Every n seconds when the "Wifi settings" window is open This is already what it does. > Please, it will do the great job without draining battery.
Attachment 368672 [details] pushed as 84279c4 - network: Request periodic Wi-Fi scans Attachment 368673 [details] pushed as e047753 - wifi: Show the "Wi-Fi disabled" page if it is disabled
Hi Bastian, I talked about this : https://dflinux.frama.io/thebeginnershandbook/img/deb9-wifi-gnome-2.png
(In reply to usbkey9 from comment #16) > Hi Bastian, > > I talked about this : > https://dflinux.frama.io/thebeginnershandbook/img/deb9-wifi-gnome-2.png Yeah, not in the Settings.
Which product is concerned ? (gnome-shell or networkManager)
(In reply to usbkey9 from comment #18) > Which product is concerned ? (gnome-shell or networkManager) gnome-shell, and it's already how it behaves. I'm not sure why you think it behaves any differently...
Oh my apologizes, I think this is because there isn't indication of refreshing ...
I can't find gnome-shell in New Bug Reporting nether access https://bugzilla.gnome.org/enter_bug.cgi?product=shell Can you do something please
(In reply to usbkey9 from comment #21) > I can't find gnome-shell in New Bug Reporting nether access > https://bugzilla.gnome.org/enter_bug.cgi?product=shell > Can you do something please GNOME Shell has moved to https://gitlab.gnome.org/GNOME/gnome-shell/issues
Thanks Felipe