GNOME Bugzilla – Bug 792243
Update the faces
Last modified: 2021-06-09 16:27:40 UTC
The faces that are included in the users panel are really old - the style is outdated and they are too small for modern designs as well as hidpi screens. As a part of redesigning the avatar picker UI [1], I recently curated a new set of images [2] using CC0 licensed images from pexel.com. The images are 512x512 in size, although the originals of all the images are much bigger. It would be great if the new images could replace the old ones in the UI. Now might also be a good time to think about making them available at a range of sizes, like we do for icons. [1] https://wiki.gnome.org/Design/OS/AvatarChooser [2] https://cloud.gnome.org/index.php/s/0IhoR750nJuUTaA
Created attachment 366385 [details] [review] user-accounts: Update face images The faces that are included in the users panel are really old, the style is outdated and they are too small for modern designs as well as hidpi screens.
Created attachment 366386 [details] [review] user-accounts: Make face images bigger Now we present 72x72 faces in a 4x4 grid.
Created attachment 366387 [details] Screenshot: before (left) after (right) Preview
See also bug 704141, but I had a lot of trouble finding the Chrome OS faces again the last time I looked.
(In reply to Felipe Borges from comment #3) > Created attachment 366387 [details] > Screenshot: before (left) after (right) > > Preview The 4x4 grid looks better out of those two screenshots. Some other changes to the UI might be nice - making it a popover like in the mockup, and changing to round images. Maybe that's a separate bug though.
(In reply to Allan Day from comment #5) > (In reply to Felipe Borges from comment #3) > > Created attachment 366387 [details] > > Screenshot: before (left) after (right) > > > > Preview > > The 4x4 grid looks better out of those two screenshots. Some other changes > to the UI might be nice - making it a popover like in the mockup, and > changing to round images. Maybe that's a separate bug though. Yes, the new popover is a WIP. I will post it to another bug soon.
Review of attachment 366385 [details] [review]: This is not applicable on master due to the autotools removal. I am not sure why, but it seems that only coffee, flower, gamepad, guitar, headphones, hummingbird, mountain and plain can be set as avatars and instead of others I always see the default avatar...
Review of attachment 366386 [details] [review]: Makes sense, thanks. ::: panels/user-accounts/um-photo-dialog.c @@ +362,3 @@ g_object_unref (file); image = gtk_image_new_from_gicon (icon, GTK_ICON_SIZE_DIALOG); + gtk_image_set_pixel_size (GTK_IMAGE (image), 72); Maybe would be nice to introduce some macro for the icon size.
Created attachment 367701 [details] [review] user-accounts: Update face images The faces that are included in the users panel are really old, the style is outdated and they are too small for modern designs as well as hidpi screens.
Created attachment 367702 [details] [review] user-accounts: Make face images bigger Now we present 72x72 faces in a 4x4 grid.
(In reply to Ondrej Holy from comment #7) > Review of attachment 366385 [details] [review] [review]: > > I am not sure why, but it seems that only coffee, flower, gamepad, guitar, > headphones, hummingbird, mountain and plain can be set as avatars and > instead of others I always see the default avatar... right. I verified that the issue here is the file sizes being to big for the avatar. This way I degraded the images just enough for them to be functional. I used gimp quality level in the export jpg tool and most of them didn't require degradation under 85 (which is produces excellent results, according to the gimp documentation https://docs.gimp.org/2.4/en/gimp-images-out.html) Thanks for your reviews!
Review of attachment 367701 [details] [review]: Looks ok, thanks.
Review of attachment 367702 [details] [review]: Looks ok, thanks.
We should also increase the size of manually specified images and images from a webcam. Currently, those images are scaled down to 96x96. But then we can probably also reach the 1MB file limit. It would be nice to reduce the size somehow automatically... though not sure there is something useful in GDK for it.
Attachment 367701 [details] pushed as ffe5aac - user-accounts: Update face images Attachment 367702 [details] pushed as 0f893b7 - user-accounts: Make face images bigger
Reopening, see Comment 14.
Created attachment 368073 [details] [review] user-accounts: Allow bigger custom avatars Default set of avatars uses 512x512 currently. However, custom avatars from file, or webcam are always scaled down to 96x96. Let's increase this also to 512x512. This change should be safe, because theoretical maximal file size is 1 MB, which is equal to accountsservice limit.
Created attachment 368074 [details] [review] user-accounts: Remove custom file size limit for avatars accountsservice has 1 MB limit for avatars, however, users panels refuses to show avatars bigger than 64 KB for some historical reasons. But you can still successfully set avatars up to the accountsservice limit. Let's remove this custom limit and rely just on accountsservice limits.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.