After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791327 - Adapt to gweather_info_new() API change
Adapt to gweather_info_new() API change
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.27.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on: 791313
Blocks:
 
 
Reported: 2017-12-07 00:20 UTC by Bastien Nocera
Modified: 2017-12-11 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update weather source for API change (1.52 KB, patch)
2017-12-07 00:20 UTC, Bastien Nocera
rejected Details | Review

Description Bastien Nocera 2017-12-07 00:20:10 UTC
.
Comment 1 Bastien Nocera 2017-12-07 00:20:14 UTC
Created attachment 365168 [details] [review]
Update weather source for API change

The deprecated argument to gweather_info_new() got dropped.
Comment 2 Emmanuele Bassi (:ebassi) 2017-12-08 17:54:26 UTC
This is currently breaking e-d-s in Continuous: http://build.gnome.org/continuous/buildmaster/builds/2017/12/08/46/build/log-evolution-data-server.txt
Comment 3 Bastien Nocera 2017-12-08 18:17:51 UTC
Attachment 365168 [details] pushed as 730b4fd - Update weather source for API change
Comment 4 Milan Crha 2017-12-11 09:05:18 UTC
That could be done in backward compatible way, cannot it? I do not see a reason why I couldn't build development version of eds against stable version of libgweather. But I understand that providing something a bit more complicated could be an obstacle.
Comment 5 Bastien Nocera 2017-12-11 09:26:27 UTC
(In reply to Milan Crha from comment #4)
> That could be done in backward compatible way, cannot it? I do not see a
> reason why I couldn't build development version of eds against stable
> version of libgweather. But I understand that providing something a bit more
> complicated could be an obstacle.

You could, by detecting the version of libgweather, but it's really more trouble than it's worth. And the API is advertised as unstable ("GWEATHER_I_KNOW_THIS_IS_UNSTABLE"), even if great care was taken not to break it so often that it becomes difficult to maintain applications based on it.

I really wouldn't bother.
Comment 6 Milan Crha 2017-12-11 09:34:18 UTC
Not talking that depending on unreleased software is rather suboptimal. Even the commit message doesn't follow usual eds way of writing commit messages, which doesn't matter that much, because I reverted your change and made it right.

Created commit d45a5b626 in eds master (3.27.3+)
Comment 7 Milan Crha 2017-12-11 09:35:10 UTC
(In reply to Bastien Nocera from comment #5)
> I really wouldn't bother.

Yes, yes, I like these selfish statements sooooooo much...
Comment 8 Bastien Nocera 2017-12-11 09:45:31 UTC
(In reply to Milan Crha from comment #7)
> (In reply to Bastien Nocera from comment #5)
> > I really wouldn't bother.
> 
> Yes, yes, I like these selfish statements sooooooo much...

This is an idiom that means "it's not worth the time, given the benefit". That doesn't mean I don't care. You've probably parsed that the wrong way.

I also don't know or use CMake, so I'm glad you fixed it.
Comment 9 Milan Crha 2017-12-11 10:33:40 UTC
(In reply to Bastien Nocera from comment #8)
> This is an idiom that means "it's not worth the time, given the benefit".
> That doesn't mean I don't care. You've probably parsed that the wrong way.

Oh, I'm sorry, I didn't know that. Though the outcome is particularly the same, as I'm going to update also Fedora Rawhide, where I do not expect unreleased libgweather being available yet, which would be a blocker for sure. Anyway, never mind, just do not be that much in hurry next time and coordinate the deprecated parameter removal beforehand, if possible (not deprecated function, there's a difference between the two).
Comment 10 Bastien Nocera 2017-12-11 10:46:12 UTC
Today is devel tarballs release day. I'm sure it could have waited a couple of hours, or a day, while we prepare a new libgweather tarball.