GNOME Bugzilla – Bug 790923
Drop the old shell code
Last modified: 2017-11-28 19:06:51 UTC
We're not shipping it anymore, and it can be safely dropped.
Created attachment 364536 [details] [review] project: Drop the old shell This is not used anymore, and is only consuming compile time now.
Created attachment 364537 [details] [review] shell-model: Remove old categories Since we don't maintain two different shells anymore, there is no need to maintain the two different sets of categories in the desktop files. This commit also drops the "#ifdef CC_ENABLE_ALT_CATEGORIES" blocks, since the previous commit removed that define.
Created attachment 364538 [details] [review] project: Remove CcInfoPanel This panel was hidden in the new shell, and now that we don't have the old one, can be safely dropped. Minor adjustments were made to the other panels to properly remove this panel.
Created attachment 364539 [details] [review] shell-model: Remove hidden category No more panels are hidden now.
Review of attachment 364536 [details] [review]: ++
Review of attachment 364537 [details] [review]: seems fine
Review of attachment 364538 [details] [review]: lgtm
Review of attachment 364539 [details] [review]: otherwise fine ::: shell/cc-panel-loader.c @@ +190,3 @@ * that are only visible in the new Shell. */ + cc_shell_model_add_item (model, category, G_APP_INFO (app), all_panels[i].name); the comment above should go too
Thanks for the review. Fixed the last commit as suggested. Attachment 364536 [details] pushed as 34f1acd - project: Drop the old shell Attachment 364537 [details] pushed as b23ef59 - shell-model: Remove old categories Attachment 364538 [details] pushed as 6123d97 - project: Remove CcInfoPanel Attachment 364539 [details] pushed as c13de50 - shell-model: Remove hidden category