After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789751 - msdk: adds vp8 decoder
msdk: adds vp8 decoder
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 789886
 
 
Reported: 2017-11-01 09:07 UTC by Hyunjun Ko
Modified: 2017-11-04 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
msdk: adds msdkvp8dec (9.33 KB, patch)
2017-11-01 09:08 UTC, Hyunjun Ko 		committed Details | Review
msdk: fix to build msdkvp8dec with mfx_dispatch (870 bytes, patch)
2017-11-03 01:56 UTC, Hyunjun Ko 		none Details | Review
msdk: fix to build msdkvp8dec with mfx_dispatch (893 bytes, patch)
2017-11-03 01:58 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2017-11-01 09:07:28 UTC 
Implements VP8 decoder using vp8 hw plugin in mediasdk.
Comment 1 Hyunjun Ko 2017-11-01 09:08:30 UTC 
Created attachment 362725 [details] [review]
msdk: adds msdkvp8dec
Comment 2 Sebastian Dröge (slomo) 2017-11-01 09:34:14 UTC 
Attachment 362725 [details] pushed as cd2dca6 - msdk: adds msdkvp8dec
Comment 3 Sebastian Dröge (slomo) 2017-11-01 16:18:24 UTC 
This breaks compilation with mfx_dispatch from https://github.com/lu-zero/mfx_dispatch

There is no mfxvp8.h there.
Comment 4 Hyunjun Ko 2017-11-02 01:48:47 UTC 
(In reply to Sebastian Dröge (slomo) from comment #3)
> This breaks compilation with mfx_dispatch from
> https://github.com/lu-zero/mfx_dispatch
> 
> There is no mfxvp8.h there.

Sorry about this but I'm working on CentOS now for gst-msdk.
IIUC mfx_dispatch is for Windows.
I can't test/build on it now. Could you do this?

By the way there is mfxvp8.h in mfx_dispatch.
Comment 5 Sebastian Dröge (slomo) 2017-11-02 08:19:08 UTC 
Indeed, I'll fix it up.

I'm using mfx_dispatch on Linux for testing compilation (and doing the actual development), and then later test running it all on Windows.
Comment 6 sreerenj 2017-11-02 19:11:40 UTC 
(In reply to Sebastian Dröge (slomo) from comment #5)
> Indeed, I'll fix it up.
> 
> I'm using mfx_dispatch on Linux for testing compilation (and doing the
> actual development), and then later test running it all on Windows.

Hi Sebastian,
Are you currently working with gst-msdk?
Then we all need to sync up :)
Comment 7 Hyunjun Ko 2017-11-03 01:56:10 UTC 
Created attachment 362860 [details] [review]
msdk: fix to build msdkvp8dec with mfx_dispatch
Comment 8 Hyunjun Ko 2017-11-03 01:58:55 UTC 
Created attachment 362861 [details] [review]
msdk: fix to build msdkvp8dec with mfx_dispatch
Comment 9 Hyunjun Ko 2017-11-03 02:00:18 UTC 
(In reply to Sebastian Dröge (slomo) from comment #5)
> Indeed, I'll fix it up.
> 
> I'm using mfx_dispatch on Linux for testing compilation (and doing the
> actual development), and then later test running it all on Windows.

Ah I didn't know I can do it on Linux with mfx_dispatch.
I hope this patch could fix the build failure.
Comment 10 Sebastian Dröge (slomo) 2017-11-03 08:21:28 UTC 
Comment on attachment 362861 [details] [review]
msdk: fix to build msdkvp8dec with mfx_dispatch

Yes that fixes it, I also had this patch locally but forgot to actually push it :) Let's get yours in
Comment 11 Sebastian Dröge (slomo) 2017-11-03 08:21:56 UTC 
(In reply to sreerenj from comment #6)

> Are you currently working with gst-msdk?
> Then we all need to sync up :)

I'm only adding VPP support to the encoder so that it can also accept various other color formats
Comment 12 Sebastian Dröge (slomo) 2017-11-04 09:15:09 UTC 
Attachment 362861 [details] pushed as 66d2bce - msdk: fix to build msdkvp8dec with mfx_dispatch