After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788807 - [XLSX] Roundtrip problem for contour graph
[XLSX] Roundtrip problem for contour graph
Status: RESOLVED OBSOLETE
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2017-10-11 01:36 UTC by Andreas J. Guelzow
Modified: 2018-05-22 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Andreas J. Guelzow 2017-10-11 01:36:42 UTC
According to Morten: The example contour plot of bug #788728 does not round-trip through xlsx. We seem to write it but not read it.
Comment 1 Morten Welinder 2017-10-21 21:43:14 UTC
We write *something*, not necessarily what is right.

Starting with attachment 361335 [details], an XL generated contour graph.

I have fixed up axis import and it looks mostly right.  Series, not so much.

There are 4 <c:ser> tags in the file.  We seem to want only one series.
I am not sure what that is about.

# xmllint --format xl/charts/chart1.xml | egrep '</?(c:ser|c:f)>'
        <c:ser>
              <c:f>Sheet1!$B$2:$B$2</c:f>
              <c:f>Sheet1!$C$1:$J$1</c:f>
              <c:f>Sheet1!$C$2:$J$2</c:f>
        </c:ser>
        <c:ser>
              <c:f>Sheet1!$B$3:$B$3</c:f>
              <c:f>Sheet1!$C$1:$J$1</c:f>
              <c:f>Sheet1!$C$3:$J$3</c:f>
        </c:ser>
        <c:ser>
              <c:f>Sheet1!$B$4:$B$4</c:f>
              <c:f>Sheet1!$C$1:$J$1</c:f>
              <c:f>Sheet1!$C$4:$J$4</c:f>
        </c:ser>
        <c:ser>
              <c:f>Sheet1!$B$5:$B$5</c:f>
              <c:f>Sheet1!$C$1:$J$1</c:f>
              <c:f>Sheet1!$C$5:$J$5</c:f>
        </c:ser>


We have everything in one clump:

                <GogObject role="Series">
                  <property name="fill-type">y-origin</property>
                  <property name="interpolation">linear</property>
                  <property name="style" type="GogStyle">
                    <line auto-dash="1" auto-width="1" auto-color="0" color="33:33:33:FF"/>
                  </property>
                  <property name="id">1</property>
                  <data>
                    <dimension id="0" type="GnmGODataVector">Sheet1!$C$1:$J$1</dimension>
                    <dimension id="1" type="GnmGODataVector">Sheet1!$B$2:$B$5</dimension>
                    <dimension id="2" type="GnmGODataMatrix">Sheet1!$C$2:$J$5</dimension>
                  </data>
                </GogObject>
Comment 2 Jean Bréfort 2017-10-22 06:27:28 UTC
We don't need to have only one series if we use an XLContourPlot compatible with the way XL plays with surfaces and contours.
Comment 3 Morten Welinder 2017-10-22 23:27:48 UTC
Thanks.

I have switched to XLContourPlot and patched up axes import for that too.
I end up with...

** (/home/welinder/gnome/gnumeric/src/.libs/lt-gnumeric:9644): WARNING **: Series with no valid style in legend? Please file a bug report.

...and nothing showing in the graph area.  Still debugging.
Comment 4 Andreas J. Guelzow 2017-10-22 23:39:37 UTC
That warning is bug #788861.
Comment 5 Morten Welinder 2017-10-23 01:31:29 UTC
> That warning is bug #788861.

It's the same warning, but the patch does not fix it -- possible because
this is a contour plot whereas the one in bug 788861 is a surface plot.
Comment 6 Andreas J. Guelzow 2017-10-23 02:02:25 UTC
I guess we should have the same patch for xl_contour_plot_class_init.
Comment 7 Jean Bréfort 2017-10-23 06:12:00 UTC
No, we should not need the same patch since XLContourPlot derives fom GogContourPlot where the foreach_elem method is already implemented. The warning looks weird to me. I'll have a look.
Comment 8 Jean Bréfort 2017-10-23 09:38:34 UTC
Fixed the plot rendering.
Comment 9 GNOME Infrastructure Team 2018-05-22 14:30:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnumeric/issues/324.