After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786612 - Sidebar styling should be more consistent with GtkPlacesSidebar
Sidebar styling should be more consistent with GtkPlacesSidebar
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 786613
Blocks:
 
 
Reported: 2017-08-22 13:51 UTC by Alexander Mikhaylenko
Modified: 2017-08-23 13:17 UTC
See Also:
GNOME target: ---
GNOME version: 3.25/3.26

Attachments
panel-list: Update icon and label classes (3.17 KB, patch)
2017-08-22 14:09 UTC, Alexander Mikhaylenko 		committed Details | Review
panel-list: Further tweak sidebar classes (2.87 KB, patch)
2017-08-23 13:05 UTC, Alexander Mikhaylenko 		committed Details | Review

Description Alexander Mikhaylenko 2017-08-22 13:51:51 UTC 
Currently they have 0.55 value. Jimmac suggests 0.7.
Comment 1 Alexander Mikhaylenko 2017-08-22 14:09:15 UTC 
Created attachment 358151 [details] [review]
panel-list: Update icon and label classes

Set icon class to sidebar-icon, and label class to
sidebar-label. This makes it more consistent with
places sidebar in Nautilus and GtkFileChooser.
Comment 2 Rui Matos 2017-08-23 12:33:48 UTC 
Review of attachment 358151 [details] [review]:

looks fine, thanks
Comment 3 Rui Matos 2017-08-23 12:34:42 UTC 
Attachment 358151 [details] pushed as b8d1e8a - panel-list: Update icon and label classes
Comment 4 Alexander Mikhaylenko 2017-08-23 13:05:40 UTC 
Created attachment 358232 [details] [review]
panel-list: Further tweak sidebar classes

An additional patch. I'm not at home at the moment, so something may be wrong.
Basically, Lapo decided that they only allow sidebar-icon, but not sidebar-label, and also to add sidebar-icon to arrows on the right side of Details and Devices.
Comment 5 Alexander Mikhaylenko 2017-08-23 13:07:10 UTC 
Lapo Calamandrei rejected Jimmac's patch, so some additional changes. Sorry for the churn :/
Comment 6 Rui Matos 2017-08-23 13:15:41 UTC 
Review of attachment 358232 [details] [review]:

sure
Comment 7 Rui Matos 2017-08-23 13:17:34 UTC 
Attachment 358232 [details] pushed as ded1b10 - panel-list: Further tweak sidebar classes