GNOME Bugzilla – Bug 786342
TIFF loader is not being built
Last modified: 2017-11-30 01:53:31 UTC
The TIFF loader is no longer being built even though the libtiff library is detected. I think the problem is in the following commit: https://git.gnome.org/browse/gdk-pixbuf/commit/?id=0927eb3e278e998248f3022c096b4f93685c6a9d PKG_CHECK_MODULES macro sets TIFF_LIBS variable instead of the formerly used LIBTIFF, but other parts of the build system files still expect LIBTIFF, eg.: AM_CONDITIONAL(HAVE_TIFF, test "x$LIBTIFF" != x) libpixbufloader_tiff_la_LIBADD = $(LIBTIFF) $(module_libs)
*** Bug 786383 has been marked as a duplicate of this bug. ***
Since my bug was closed as a duplicate please note that in my case the effects are much more severe. I don't get a working build with missing tiff loader, but instead the build fails completely because it *does* compile the libtiff stuff but then forgets to link against it.
FYI, 2.38.9 is still affected: [..] CC gdk-pixbuf-csource.o CCLD gdk-pixbuf-csource ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFWriteScanline' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFClose' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetErrorHandler' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFGetField' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFIsCODECConfigured' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFClientOpen' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetField' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFReadDirectory' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetWarningHandler' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFReadRGBAImageOriented' ./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFFdOpen' [..] Makefile:1874: recipe for target 'gdk-pixbuf-csource' failed
2.36.9, of course. Sorry.
Created attachment 359549 [details] [review] build: Fix TIFF loader compilation with autotools
Above is an untested patch. As a sidenote, both jhbuild and gnome-continuous use meson to build gdk-pixbuf, which is why this wouldn't have got caught. Let me know whether that fixes the problem for you.
(In reply to Bastien Nocera from comment #6) > Above is an untested patch. As a sidenote, both jhbuild and gnome-continuous > use meson to build gdk-pixbuf, which is why this wouldn't have got caught. > > Let me know whether that fixes the problem for you. The patch fixes the issue for me, thank you.
Attachment 359549 [details] pushed as 66537d1 - build: Fix TIFF loader compilation with autotools
Note that with this change, building without the tiff library installed no longer works, even if --without-libtiff is passed to configure. The build attempts to compile io-tiff.c, and fails when tiffio.h is not found. See https://bugs.gentoo.org/show_bug.cgi?id=631088 for more details. Please let me know if this ought to be filed as a new bug instead.
Please file a new bug if this still happens with git master, thanks.