GNOME Bugzilla – Bug 784624
process-stop-symbolic hardcoded as app menu fallback
Last modified: 2017-10-09 11:25:34 UTC
Right now `process-stop-symbolic` icon is hardcoded as the app menu fallback icon. This is problematic, however, as stopping a process is not appropriate metaphor for a menu. A more appropriate icon could be open-menu-symbolic. This issue has caused several bug reports against elementary OS with users confused by the icon, thinking it was a close icon. https://github.com/elementary/gala/issues/28 https://bugs.launchpad.net/elementaryos/+bug/1300022 https://github.com/elementary/icons/issues/222 I filed a Pull Request on GitHub, but was told to use BugZilla. https://github.com/GNOME/gtk/pull/18
Yes, I noticed this on Windows too but forgot to submit a bug yet.
Daniel Fore previously commented that `view-more-symbolic` could also work as a fallback icon. That makes sense to me if we want to avoid the case where an app has both fallback app menu and its own menu with `open-menu-symbolic`
Created attachment 355025 [details] [review] Change process-stop-symbolic to open-menu-symbolic for app menu fallback icon
(In reply to Cassidy James from comment #2) > Daniel Fore previously commented that `view-more-symbolic` could also work > as a fallback icon. That makes sense to me if we want to avoid the case > where an app has both fallback app menu and its own menu with > `open-menu-symbolic` Indeed, the one thing that process-stop-symbolic has going for it is that it is unlikely to occur elsewhere in a headerbar... So something less likely to clash is needed. view-more is unlikely to, I guess, but I wonder if anyone has a better idea.
(In reply to Daniel Boles from comment #4) > Indeed, the one thing that process-stop-symbolic has going for it is that it > is unlikely to occur elsewhere in a headerbar... Heh, this was not intended as sarcasm, but on reflection it should've been, as I just saw in your linked tickets that some themes have it using the same icon as the window close button. So that's much, much worse! Definitely needs changing. On Windows, with the default Adwaita icon theme, this icon is a stop sign.
It is not hardcoded, really: if (!_gtk_header_bar_update_window_icon (bar, window)) gtk_image_set_from_icon_name (GTK_IMAGE (priv->titlebar_icon), "process-stop-symbolic", GTK_ICON_SIZE_MENU); We only use it if we can't get a window icon to use. I agree that it would be nice to not misuse process-stop-symbolic here. But I don't want to use an icon that is likely to be used elsewhere in the headerbar. We could use application-x-executable, which is used elsewhere as a fallback for the case of 'missing app icon'.
*** Bug 766915 has been marked as a duplicate of this bug. ***
(In reply to Matthias Clasen from comment #6) > I agree that it would be nice to not misuse process-stop-symbolic here. But > I don't want to use an icon that is likely to be used elsewhere in the > headerbar. > > We could use application-x-executable, which is used elsewhere as a fallback > for the case of 'missing app icon'. That's ideal - I've pushed commits to do this