Created attachment 353493 [details] [review]
build: Add meson support

Review of attachment 353493 [details] [review]:

Not a meson guru, but this looks generally good to me with a couple minor comments.

::: src/meson.build
@@ +47,3 @@
+)
+
+service_conf = configuration_data ()

Can't help but notice that all the other "function calls" don't have a space before the paren

::: src/org.gnome.font-viewer.service.in
@@ +1,3 @@
+[D-BUS Service]
+Name=org.gnome.font-viewer
+Exec=@BINDIR@gnome-font-viewer --gapplication-service

This is also created by the autotools build, so I'd prefer if you split it into a separate file first.

Created attachment 353495 [details] [review]
build: Place D-Bus service in its own file

Created attachment 353496 [details] [review]
build: Add meson support

https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting

Created attachment 353497 [details] [review]
3.26: Switch gnome-font-viewer to meson

and drop intltool dependency

This patch is for jhbuild.

I meant to have 783611 and 783612 to be part of this bug too but I mixed up the git bz syntax.

Review of attachment 353495 [details] [review]:

Looks good with the change below

::: src/Makefile.am
@@ +59,3 @@
+servicedir = $(datadir)/dbus-1/services
+service_in_files = org.gnome.font-viewer.service.in
+service_DATA = $(service_in_files:.service.in=.service)

Please reuse the variables above

Review of attachment 353496 [details] [review]:

Looks good

Review of attachment 353497 [details] [review]:

OK

Created attachment 353541 [details] [review]
build: Place D-Bus service in its own file

Review of attachment 353541 [details] [review]:

Looks good

Attachment 353496 [details] pushed as 798a942 - build: Add meson support
Attachment 353541 [details] pushed as 08d1f19 - build: Place D-Bus service in its own file

Comment on attachment 353497 [details] [review]
3.26: Switch gnome-font-viewer to meson

Attachment 353497 [details] pushed as aeae1ae - 3.26: Switch gnome-font-viewer to meson

Can we close the ticket, or is there anything else to do?

Created attachment 353543 [details] [review]
build: Remove autotools support

It looks like gnome-continuous has built gnome-font-viewer successfully with meson:

https://build.gnome.org/continuous/buildmaster/builds/2017/06/10/32/build/

The next version of meson 0.41 is expected soon with built-in ability to make tarballs.

If you need to do a tarball release before then, I recommend using
https://git.gnome.org/browse/epiphany/tree/make_release.sh
but change the name from 'epiphany'

Review of attachment 353543 [details] [review]:

Let's go for this, assuming that you have tested the build and it produced all the expected output.

Attachment 353543 [details] pushed as ea583a0 - build: Remove autotools support