GNOME Bugzilla – Bug 780157
appFavorites: Rename gnome-music.desktop
Last modified: 2017-04-11 09:52:52 UTC
.
Created attachment 348108 [details] [review] appFavorites: Rename gnome-music.desktop Recently Music gained a flatpak manifest inside the repo in bug 779905. However that requires the desktop file to be properly named like DBUS addresses are. This patch renames the old Music desktop file to the new one.
Review of attachment 348108 [details] [review]: ::: js/ui/appFavorites.js @@ +40,3 @@ 'polari.desktop': 'org.gnome.Polari.desktop', 'totem.desktop': 'org.gnome.Totem.desktop', + 'gnome-music.desktop': 'org.gnome.Music.desktop', The list is supposed to be in alphabetical order
Created attachment 348109 [details] [review] appFavorites: Rename gnome-music.desktop Recently Music gained a flatpak manifest inside the repo in bug 779905. However that requires the desktop file to be properly named like DBUS addresses are. This patch renames the old Music desktop file to the new one.
Review of attachment 348109 [details] [review]: OK
Attachment 348109 [details] pushed as 2cce1b9 - appFavorites: Rename gnome-music.desktop
You need to push this commit to the gnome-3.24 branch since you the rename was released in gnome-music 3.24.1.
Hey, as mentioned in the gnome-music bug, that's an error. So this patch is fine in master.
(In reply to Carlos Soriano from comment #7) > So this patch is fine in master. The patch is fine(*) either way - since commit 2c5bc4a1a9, we'll still use the old name when the new .desktop file cannot be found. (*) except that I just noticed that you add the "// alphabetical order" comment, and then sort 'm' after 'n' ;-)
:((((