GNOME Bugzilla – Bug 780154
Add a "Open terminal in flatpak enviroment" menu item
Last modified: 2018-01-11 10:21:36 UTC
Right now we have in the hamburguer menu Open terminal and a item menu called Flatpak that have some specific options in it. It would be cool to present also a menu item for opening a terminal in flatpak environment This is alreayd possible with the ctrl+alt+shift+t shortcut, so the code is already in there, only thing missing is the menu item. For now it probably should be inside the Flatpak submenu, and if in the future we have some abstraction layer, we can put a more generic "Open terminal in sandbox build environment" or so. This is a good task for newcomers once the maintainers agrees.
This feature is not Flatpak specific, so it seems weird to put it under the flatpak menu. It is just a terminal inside your build environment (could be on the host, could be inside of jhbuild, could be inside of flatpak). But yes, it would be nice to have some UI somewhere for this.
Created attachment 349533 [details] [review] terminal: Add Runtime Terminal action to menu
Review of attachment 349533 [details] [review]: LGTM Should we specify build vs app terminal? Also push to stable branch
Pushed as commit eb15290a3 and commit c7c7aec02. Do we have ways to open both?
we do not yet. its possible to add, it just sort of complicates the spawning code in gb-terminal-view.c, and we probably need to use IdeRunner so that we get finish-args and such.
We have a "New Stuff Button" in the header bar now, which has a new terminal menu item. I think we should probably move this there as well. Since the runtime terminal currently is based around the build environment more than runtime, we should probably name it "New build terminal" or something like that. We can/should probably have a way to do the run terminal but that still requires work in the terminal plugin to access the runner.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-builder/issues/194.